You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hama.apache.org by "Filipe Manana (JIRA)" <ji...@apache.org> on 2010/08/24 19:32:18 UTC
[jira] Created: (HAMA-283) Duplicate code regarding default
configuration files for Hama
Duplicate code regarding default configuration files for Hama
-------------------------------------------------------------
Key: HAMA-283
URL: https://issues.apache.org/jira/browse/HAMA-283
Project: Hama
Issue Type: Question
Reporter: Filipe Manana
Priority: Trivial
While doing my first Hama code walks, I noticed the exact same static block initializer in the classes BSPMaster, GroomServer and BSPJobContext:
static {
Configuration.addDefaultResource("hama-default.xml");
Configuration.addDefaultResource("hama-site.xml");
}
However, in the org.apache.hama.HamaConfiguration class the constructor calls the following method:
private void addHamaResources() {
Configuration.addDefaultResource("hama-default.xml");
Configuration.addDefaultResource("hama-site.xml");
}
Correct me if I'm wrong, but this does exactly the same, right?
With the following patch, which removes the static initializers, all the tests are passing.
cheers
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HAMA-283) Duplicate code regarding default
configuration files for Hama
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon reassigned HAMA-283:
-----------------------------------
Assignee: Filipe Manana
> Duplicate code regarding default configuration files for Hama
> -------------------------------------------------------------
>
> Key: HAMA-283
> URL: https://issues.apache.org/jira/browse/HAMA-283
> Project: Hama
> Issue Type: Question
> Reporter: Filipe Manana
> Assignee: Filipe Manana
> Priority: Trivial
> Attachments: HAMA-283.patch
>
>
> While doing my first Hama code walks, I noticed the exact same static block initializer in the classes BSPMaster, GroomServer and BSPJobContext:
> static {
> Configuration.addDefaultResource("hama-default.xml");
> Configuration.addDefaultResource("hama-site.xml");
> }
> However, in the org.apache.hama.HamaConfiguration class the constructor calls the following method:
> private void addHamaResources() {
> Configuration.addDefaultResource("hama-default.xml");
> Configuration.addDefaultResource("hama-site.xml");
> }
> Correct me if I'm wrong, but this does exactly the same, right?
> With the following patch, which removes the static initializers, all the tests are passing.
> cheers
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HAMA-283) Duplicate code regarding default
configuration files for Hama
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon resolved HAMA-283.
---------------------------------
Fix Version/s: 0.2.0
Resolution: Fixed
I've just committed this. hard coded path of conf files also removed.
Thanks Filipe.
> Duplicate code regarding default configuration files for Hama
> -------------------------------------------------------------
>
> Key: HAMA-283
> URL: https://issues.apache.org/jira/browse/HAMA-283
> Project: Hama
> Issue Type: Question
> Reporter: Filipe Manana
> Assignee: Filipe Manana
> Priority: Trivial
> Fix For: 0.2.0
>
> Attachments: HAMA-283.patch
>
>
> While doing my first Hama code walks, I noticed the exact same static block initializer in the classes BSPMaster, GroomServer and BSPJobContext:
> static {
> Configuration.addDefaultResource("hama-default.xml");
> Configuration.addDefaultResource("hama-site.xml");
> }
> However, in the org.apache.hama.HamaConfiguration class the constructor calls the following method:
> private void addHamaResources() {
> Configuration.addDefaultResource("hama-default.xml");
> Configuration.addDefaultResource("hama-site.xml");
> }
> Correct me if I'm wrong, but this does exactly the same, right?
> With the following patch, which removes the static initializers, all the tests are passing.
> cheers
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-283) Duplicate code regarding default
configuration files for Hama
Posted by "Filipe Manana (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filipe Manana updated HAMA-283:
-------------------------------
Attachment: HAMA-283.patch
the patch attachment
> Duplicate code regarding default configuration files for Hama
> -------------------------------------------------------------
>
> Key: HAMA-283
> URL: https://issues.apache.org/jira/browse/HAMA-283
> Project: Hama
> Issue Type: Question
> Reporter: Filipe Manana
> Priority: Trivial
> Attachments: HAMA-283.patch
>
>
> While doing my first Hama code walks, I noticed the exact same static block initializer in the classes BSPMaster, GroomServer and BSPJobContext:
> static {
> Configuration.addDefaultResource("hama-default.xml");
> Configuration.addDefaultResource("hama-site.xml");
> }
> However, in the org.apache.hama.HamaConfiguration class the constructor calls the following method:
> private void addHamaResources() {
> Configuration.addDefaultResource("hama-default.xml");
> Configuration.addDefaultResource("hama-site.xml");
> }
> Correct me if I'm wrong, but this does exactly the same, right?
> With the following patch, which removes the static initializers, all the tests are passing.
> cheers
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-283) Duplicate code regarding default
configuration files for Hama
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902152#action_12902152 ]
Edward J. Yoon commented on HAMA-283:
-------------------------------------
obviously it's unnecessary +1
> Duplicate code regarding default configuration files for Hama
> -------------------------------------------------------------
>
> Key: HAMA-283
> URL: https://issues.apache.org/jira/browse/HAMA-283
> Project: Hama
> Issue Type: Question
> Reporter: Filipe Manana
> Assignee: Filipe Manana
> Priority: Trivial
> Attachments: HAMA-283.patch
>
>
> While doing my first Hama code walks, I noticed the exact same static block initializer in the classes BSPMaster, GroomServer and BSPJobContext:
> static {
> Configuration.addDefaultResource("hama-default.xml");
> Configuration.addDefaultResource("hama-site.xml");
> }
> However, in the org.apache.hama.HamaConfiguration class the constructor calls the following method:
> private void addHamaResources() {
> Configuration.addDefaultResource("hama-default.xml");
> Configuration.addDefaultResource("hama-site.xml");
> }
> Correct me if I'm wrong, but this does exactly the same, right?
> With the following patch, which removes the static initializers, all the tests are passing.
> cheers
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.