[GitHub] [jena] afs commented on a diff in pull request #1832: improvement: JENA-2350 Pass JsonLdOptions to titanium for json-ld 1.1

["afs (via GitHub)" <gi...@apache.org>]

afs commented on code in PR #1832:
URL: https://github.com/apache/jena/pull/1832#discussion_r1159701725


##########
jena-arq/src/test/java/org/apache/jena/riot/lang/TestLangJSONLD11.java:
##########
@@ -0,0 +1,60 @@
+package org.apache.jena.riot.lang;
+
+import static org.junit.Assert.assertEquals;
+
+import java.net.URI;
+
+import org.apache.jena.riot.Lang;
+import org.apache.jena.riot.RDFParserBuilder;
+import org.apache.jena.sparql.util.Context;
+import org.junit.Test;
+
+import com.apicatalog.jsonld.JsonLdError;
+import com.apicatalog.jsonld.JsonLdOptions;
+import com.apicatalog.jsonld.document.Document;
+import com.apicatalog.jsonld.loader.DocumentLoader;
+import com.apicatalog.jsonld.loader.DocumentLoaderOptions;
+import com.apicatalog.jsonld.loader.HttpLoader;
+
+public class TestLangJSONLD11 {
+	
+	private static final Lang LANG = Lang.JSONLD11;

Review Comment:
   Might as well not have this constant and have a static input of Lang.JSONLD11, and use `JSONLD11` in tests.



##########
jena-arq/src/test/java/org/apache/jena/riot/lang/TestLangJSONLD11.java:
##########
@@ -0,0 +1,60 @@
+package org.apache.jena.riot.lang;
+
+import static org.junit.Assert.assertEquals;
+
+import java.net.URI;
+
+import org.apache.jena.riot.Lang;
+import org.apache.jena.riot.RDFParserBuilder;
+import org.apache.jena.sparql.util.Context;
+import org.junit.Test;
+
+import com.apicatalog.jsonld.JsonLdError;
+import com.apicatalog.jsonld.JsonLdOptions;
+import com.apicatalog.jsonld.document.Document;
+import com.apicatalog.jsonld.loader.DocumentLoader;
+import com.apicatalog.jsonld.loader.DocumentLoaderOptions;
+import com.apicatalog.jsonld.loader.HttpLoader;
+
+public class TestLangJSONLD11 {
+	
+	private static final Lang LANG = Lang.JSONLD11;
+	private static final String CONTENT = "";
+
+	@Test
+	public void testGetJsonLdOptions() {
+		RDFParserBuilder.create()
+			.context(setupContext())
+			.forceLang(LANG)

Review Comment:
   ```suggestion
   			.lang(JSONLD11)
   ```
   `lang` is sufficient. `forceLang` is only needed if the source name (URL, filename, content negoitation) gives a different answer.



##########
jena-arq/src/test/java/org/apache/jena/riot/lang/TestLangJSONLD11.java:
##########
@@ -0,0 +1,60 @@
+package org.apache.jena.riot.lang;
+
+import static org.junit.Assert.assertEquals;
+
+import java.net.URI;
+
+import org.apache.jena.riot.Lang;
+import org.apache.jena.riot.RDFParserBuilder;
+import org.apache.jena.sparql.util.Context;
+import org.junit.Test;
+
+import com.apicatalog.jsonld.JsonLdError;
+import com.apicatalog.jsonld.JsonLdOptions;
+import com.apicatalog.jsonld.document.Document;
+import com.apicatalog.jsonld.loader.DocumentLoader;
+import com.apicatalog.jsonld.loader.DocumentLoaderOptions;
+import com.apicatalog.jsonld.loader.HttpLoader;
+
+public class TestLangJSONLD11 {
+	
+	private static final Lang LANG = Lang.JSONLD11;
+	private static final String CONTENT = "";
+
+	@Test
+	public void testGetJsonLdOptions() {
+		RDFParserBuilder.create()
+			.context(setupContext())
+			.forceLang(LANG)
+			.fromString(CONTENT)
+			.build();
+		
+		assertEquals("Custom DocumentLoader was called to handle loading", 1, TestDocumentLoader.COUNTER);

Review Comment:
   Shouldn't the message be:
   
   "Custom DocumentLoader was not called to handle loading"
   
   The message is printed on error.



##########
jena-arq/src/test/java/org/apache/jena/riot/lang/TestLangJSONLD11.java:
##########
@@ -0,0 +1,60 @@
+package org.apache.jena.riot.lang;
+
+import static org.junit.Assert.assertEquals;
+
+import java.net.URI;
+
+import org.apache.jena.riot.Lang;
+import org.apache.jena.riot.RDFParserBuilder;
+import org.apache.jena.sparql.util.Context;
+import org.junit.Test;
+
+import com.apicatalog.jsonld.JsonLdError;
+import com.apicatalog.jsonld.JsonLdOptions;
+import com.apicatalog.jsonld.document.Document;
+import com.apicatalog.jsonld.loader.DocumentLoader;
+import com.apicatalog.jsonld.loader.DocumentLoaderOptions;
+import com.apicatalog.jsonld.loader.HttpLoader;
+
+public class TestLangJSONLD11 {
+	
+	private static final Lang LANG = Lang.JSONLD11;
+	private static final String CONTENT = "";
+
+	@Test
+	public void testGetJsonLdOptions() {
+		RDFParserBuilder.create()

Review Comment:
   Please convert tabs to spaces. We use 4 space indent.
   
   (Now there is github, display of files online matters a bit more)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org