You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Hyrum K. Wright" <hy...@mail.utexas.edu> on 2006/12/03 02:19:34 UTC

[PATCH] Relative path copy and move tests

While working the multiple moves branch, I've expanded the relative move
test added in r20698.  These are general tests, not specific to the
multiple moves branch, so I'd like them added to trunk.  I've also moved
the original test from basic_tests.py to copy_tests.py.

For the curious, they are marked XFail due to a known bug in windows
apr.  See issue 1869 for details.

-Hyrum

[[[
Followup to r20698, move and expand copy and move tests regarding
relative paths.

* subversion/tests/cmdline/basic_tests.py
  (move_relative_paths): Rename and move to copy_tests.py

* subversion/tests/cmdline/copy_tests.py
  (move_to_relative_paths): Copied from basic_tests.py.
  (move_from_relative_paths, copy_to_relative_paths,
  copy_from_relative_paths):
  New, mostly copied from move_to_relative_path().
]]]

Re: [PATCH] Relative path copy and move tests

Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
Lieven Govaerts wrote:
> Hyrum K. Wright wrote:
>> While working the multiple moves branch, I've expanded the relative move
>> test added in r20698.  These are general tests, not specific to the
>> multiple moves branch, so I'd like them added to trunk.  I've also moved
>> the original test from basic_tests.py to copy_tests.py.
>>   
> Yep.
> 
>> For the curious, they are marked XFail due to a known bug in windows
>> apr.  See issue 1869 for details.
>>   
> Well, no. That issue only affects relative paths with 3 or more times
> '..', so basically only the move_to_relative_paths and
> copy_to_relative_paths tests should be XFail-ing, the two others (move-
> and copy_from_relative_paths) are passing correctly.
> 
> The tests are good,  +1 to commit on trunk (with XFail removed from
> those two tests).

Thanks for looking at it.  I've removed those two tests from XFail, and
committed as r22562 on trunk.

-Hyrum


Re: [PATCH] Relative path copy and move tests

Posted by Lieven Govaerts <sv...@mobsol.be>.
Hyrum K. Wright wrote:
> While working the multiple moves branch, I've expanded the relative move
> test added in r20698.  These are general tests, not specific to the
> multiple moves branch, so I'd like them added to trunk.  I've also moved
> the original test from basic_tests.py to copy_tests.py.
>   
Yep.

> For the curious, they are marked XFail due to a known bug in windows
> apr.  See issue 1869 for details.
>   
Well, no. That issue only affects relative paths with 3 or more times
'..', so basically only the move_to_relative_paths and
copy_to_relative_paths tests should be XFail-ing, the two others (move-
and copy_from_relative_paths) are passing correctly.

The tests are good,  +1 to commit on trunk (with XFail removed from
those two tests).

Lieven

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org