You are viewing a plain text version of this content. The canonical link for it is here.
Posted to axis-cvs@ws.apache.org by as...@apache.org on 2009/01/13 19:03:03 UTC
svn commit: r734201 - in /webservices/axis2/trunk/java/modules:
addressing/pom.xml saaj/pom.xml
Author: asankha
Date: Tue Jan 13 10:02:54 2009
New Revision: 734201
URL: http://svn.apache.org/viewvc?rev=734201&view=rev
Log:
make transport dependencies valid only for the testing scope in maven
Modified:
webservices/axis2/trunk/java/modules/addressing/pom.xml
webservices/axis2/trunk/java/modules/saaj/pom.xml
Modified: webservices/axis2/trunk/java/modules/addressing/pom.xml
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/addressing/pom.xml?rev=734201&r1=734200&r2=734201&view=diff
==============================================================================
--- webservices/axis2/trunk/java/modules/addressing/pom.xml (original)
+++ webservices/axis2/trunk/java/modules/addressing/pom.xml Tue Jan 13 10:02:54 2009
@@ -41,14 +41,17 @@
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>axis2-transport-http</artifactId>
+ <scope>test</scope>
</dependency>
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>axis2-transport-tcp</artifactId>
+ <scope>test</scope>
</dependency>
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>axis2-transport-local</artifactId>
+ <scope>test</scope>
</dependency>
</dependencies>
<build>
Modified: webservices/axis2/trunk/java/modules/saaj/pom.xml
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/saaj/pom.xml?rev=734201&r1=734200&r2=734201&view=diff
==============================================================================
--- webservices/axis2/trunk/java/modules/saaj/pom.xml (original)
+++ webservices/axis2/trunk/java/modules/saaj/pom.xml Tue Jan 13 10:02:54 2009
@@ -45,14 +45,17 @@
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>axis2-transport-http</artifactId>
+ <scope>test</scope>
</dependency>
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>axis2-transport-tcp</artifactId>
+ <scope>test</scope>
</dependency>
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>axis2-transport-local</artifactId>
+ <scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.axis2</groupId>
Re: svn commit: r734201 - in /webservices/axis2/trunk/java/modules: addressing/pom.xml saaj/pom.xml
Posted by Jarek Gawor <jg...@gmail.com>.
On Wed, Jan 14, 2009 at 12:37 PM, Glen Daniels <gl...@thoughtcraft.com> wrote:
> Hi Asankha, all:
>
> Asankha C. Perera wrote:
>> Hi Jarek
>>> I agree with changing the transport dependencies to test scope but in
>>> general I'm a little concerned about the circular dependency between
>>> axis2 and axis2-transport modules. Because of that circular dependency
>>> I think we have to release axis2 and axis2-transport at the same time
>>> (at least the base, local, tcp and http transport modules) and I
>>> thought the idea behind splitting transport code from Axis2 was to
>>> release the transport modules independently from Axis2.
>>>
>> Yes, for some reason some of the existing pom.xml's creates problems for
>> projects down the line, with these issues. Its important to set the
>> dependencies for runtime and testing etc correct. Also to fix the
>> dependencies to avoid any circular dependencies. I firmly believe that
>> transports need to be released separately, and its just a matter of time..
>
> +1. We've done the first step of factoring the transports, but not the
> whole enchilada. The big philosophical change we now need to make is
> that Axis2 shouldn't, aside from test code, be relying on any particular
> set of transports (except *possibly* the local one). It would also be
> really great if we could optionally run most of the Axis2 tests which
> currently use HTTP over the local transport - I would think that might
> speed up the build significantly.
A couple of comments. First, I think it is important to run tests
(some at least) over HTTP to tests stuff like session support,
cookies, response codes, etc. All of which are important from spec and
spec compliance point of view. Second, the transport dependencies in
Axis2 are not just needed in tests. We include the transport modules
in the Axis2 web application and the binary distribution. And after
somebody installs Axis2 I don't think we are going to expect them to
also download and install the basic transport jar files just to make a
simple Axis2 client working. So, I would argue that the http transport
module (and whatever it requires and maybe local and tcp) should move
back into Axis2 because they are the minimal set of transport modules
that make Axis2 work. That would also eliminate the circular
dependency problem that we have today and let other Axis2 transport
modules to be released independently from Axis2.
Jarek
Re: svn commit: r734201 - in /webservices/axis2/trunk/java/modules:
addressing/pom.xml saaj/pom.xml
Posted by Glen Daniels <gl...@thoughtcraft.com>.
Hi Asankha, all:
Asankha C. Perera wrote:
> Hi Jarek
>> I agree with changing the transport dependencies to test scope but in
>> general I'm a little concerned about the circular dependency between
>> axis2 and axis2-transport modules. Because of that circular dependency
>> I think we have to release axis2 and axis2-transport at the same time
>> (at least the base, local, tcp and http transport modules) and I
>> thought the idea behind splitting transport code from Axis2 was to
>> release the transport modules independently from Axis2.
>>
> Yes, for some reason some of the existing pom.xml's creates problems for
> projects down the line, with these issues. Its important to set the
> dependencies for runtime and testing etc correct. Also to fix the
> dependencies to avoid any circular dependencies. I firmly believe that
> transports need to be released separately, and its just a matter of time..
+1. We've done the first step of factoring the transports, but not the
whole enchilada. The big philosophical change we now need to make is
that Axis2 shouldn't, aside from test code, be relying on any particular
set of transports (except *possibly* the local one). It would also be
really great if we could optionally run most of the Axis2 tests which
currently use HTTP over the local transport - I would think that might
speed up the build significantly.
For Axis2 1.5, we DO need to get a real (non-SNAPSHOT) release of the
transports out ASAP. Will bring that up on commons-dev.
--Glen
Re: svn commit: r734201 - in /webservices/axis2/trunk/java/modules:
addressing/pom.xml saaj/pom.xml
Posted by "Asankha C. Perera" <as...@apache.org>.
Hi Jarek
> I agree with changing the transport dependencies to test scope but in
> general I'm a little concerned about the circular dependency between
> axis2 and axis2-transport modules. Because of that circular dependency
> I think we have to release axis2 and axis2-transport at the same time
> (at least the base, local, tcp and http transport modules) and I
> thought the idea behind splitting transport code from Axis2 was to
> release the transport modules independently from Axis2.
>
Yes, for some reason some of the existing pom.xml's creates problems for
projects down the line, with these issues. Its important to set the
dependencies for runtime and testing etc correct. Also to fix the
dependencies to avoid any circular dependencies. I firmly believe that
transports need to be released separately, and its just a matter of time..
thanks
asankha
>
> On Wed, Jan 14, 2009 at 4:48 AM, Andreas Veithen
> <an...@gmail.com> wrote:
>
>> Asankha,
>>
>> I agree with your changes and I share your point of view that we
>> should reduce dependencies an the transports to a minimum. From what
>> I've seen, the problem is simply that some modules depending on
>> addressing, clustering and/or saaj (the ones you changed) implicitly
>> rely on the fact that they depend on the transports. Probably it is
>> just a matter of adding them as dependencies in scope test in the
>> right places (jaxws, metadata, etc.). I would have corrected that
>> myself yesterday if it were not for the fact that it takes 50 min to
>> build the whole Axis2 project :-)
>>
>> Andreas
>>
>> On Wed, Jan 14, 2009 at 04:38, Asankha C. Perera <as...@apache.org> wrote:
>>
>>> Hi Andreas
>>>
>>>> I had to revert this change (and the previous one) because they cause
>>>> the Axis2 build to fail (not in the modules you changed, but in
>>>> modules depending on those, e.g. jaxws and metadata).
>>>>
>>>>
>>> Thanks.. and I am sorry I couldn't run the full build of Axis2.. but I did
>>> test the modules I changed, and still think that they should not make the
>>> local and tcp transports required dependencies unless they are required at
>>> runtime
>>>
>>> Having unwanted dependencies just makes it difficult for these to be used by
>>> other projects.. I will try to fix this in Axis2 again, or exclude them from
>>> the Synapse build which will just make its pom larger :(
>>>
>>> thanks
>>> asankha
>>>
--
Asankha C. Perera
http://adroitlogic.org
http://esbmagic.blogspot.com
Re: svn commit: r734201 - in /webservices/axis2/trunk/java/modules: addressing/pom.xml saaj/pom.xml
Posted by Jarek Gawor <jg...@gmail.com>.
I agree with changing the transport dependencies to test scope but in
general I'm a little concerned about the circular dependency between
axis2 and axis2-transport modules. Because of that circular dependency
I think we have to release axis2 and axis2-transport at the same time
(at least the base, local, tcp and http transport modules) and I
thought the idea behind splitting transport code from Axis2 was to
release the transport modules independently from Axis2.
Jarek
On Wed, Jan 14, 2009 at 4:48 AM, Andreas Veithen
<an...@gmail.com> wrote:
> Asankha,
>
> I agree with your changes and I share your point of view that we
> should reduce dependencies an the transports to a minimum. From what
> I've seen, the problem is simply that some modules depending on
> addressing, clustering and/or saaj (the ones you changed) implicitly
> rely on the fact that they depend on the transports. Probably it is
> just a matter of adding them as dependencies in scope test in the
> right places (jaxws, metadata, etc.). I would have corrected that
> myself yesterday if it were not for the fact that it takes 50 min to
> build the whole Axis2 project :-)
>
> Andreas
>
> On Wed, Jan 14, 2009 at 04:38, Asankha C. Perera <as...@apache.org> wrote:
>> Hi Andreas
>>>
>>> I had to revert this change (and the previous one) because they cause
>>> the Axis2 build to fail (not in the modules you changed, but in
>>> modules depending on those, e.g. jaxws and metadata).
>>>
>>
>> Thanks.. and I am sorry I couldn't run the full build of Axis2.. but I did
>> test the modules I changed, and still think that they should not make the
>> local and tcp transports required dependencies unless they are required at
>> runtime
>>
>> Having unwanted dependencies just makes it difficult for these to be used by
>> other projects.. I will try to fix this in Axis2 again, or exclude them from
>> the Synapse build which will just make its pom larger :(
>>
>> thanks
>> asankha
>>>
>>> On Tue, Jan 13, 2009 at 19:03, <as...@apache.org> wrote:
>>>
>>>>
>>>> Author: asankha
>>>> Date: Tue Jan 13 10:02:54 2009
>>>> New Revision: 734201
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=734201&view=rev
>>>> Log:
>>>> make transport dependencies valid only for the testing scope in maven
>>>>
>>
>> --
>> Asankha C. Perera
>> http://adroitlogic.org
>>
>> http://esbmagic.blogspot.com
>>
>>
>
Re: svn commit: r734201 - in /webservices/axis2/trunk/java/modules: addressing/pom.xml saaj/pom.xml
Posted by Andreas Veithen <an...@gmail.com>.
Asankha,
I agree with your changes and I share your point of view that we
should reduce dependencies an the transports to a minimum. From what
I've seen, the problem is simply that some modules depending on
addressing, clustering and/or saaj (the ones you changed) implicitly
rely on the fact that they depend on the transports. Probably it is
just a matter of adding them as dependencies in scope test in the
right places (jaxws, metadata, etc.). I would have corrected that
myself yesterday if it were not for the fact that it takes 50 min to
build the whole Axis2 project :-)
Andreas
On Wed, Jan 14, 2009 at 04:38, Asankha C. Perera <as...@apache.org> wrote:
> Hi Andreas
>>
>> I had to revert this change (and the previous one) because they cause
>> the Axis2 build to fail (not in the modules you changed, but in
>> modules depending on those, e.g. jaxws and metadata).
>>
>
> Thanks.. and I am sorry I couldn't run the full build of Axis2.. but I did
> test the modules I changed, and still think that they should not make the
> local and tcp transports required dependencies unless they are required at
> runtime
>
> Having unwanted dependencies just makes it difficult for these to be used by
> other projects.. I will try to fix this in Axis2 again, or exclude them from
> the Synapse build which will just make its pom larger :(
>
> thanks
> asankha
>>
>> On Tue, Jan 13, 2009 at 19:03, <as...@apache.org> wrote:
>>
>>>
>>> Author: asankha
>>> Date: Tue Jan 13 10:02:54 2009
>>> New Revision: 734201
>>>
>>> URL: http://svn.apache.org/viewvc?rev=734201&view=rev
>>> Log:
>>> make transport dependencies valid only for the testing scope in maven
>>>
>
> --
> Asankha C. Perera
> http://adroitlogic.org
>
> http://esbmagic.blogspot.com
>
>
Re: svn commit: r734201 - in /webservices/axis2/trunk/java/modules:
addressing/pom.xml saaj/pom.xml
Posted by "Asankha C. Perera" <as...@apache.org>.
Hi Andreas
> I had to revert this change (and the previous one) because they cause
> the Axis2 build to fail (not in the modules you changed, but in
> modules depending on those, e.g. jaxws and metadata).
>
Thanks.. and I am sorry I couldn't run the full build of Axis2.. but I
did test the modules I changed, and still think that they should not
make the local and tcp transports required dependencies unless they are
required at runtime
Having unwanted dependencies just makes it difficult for these to be
used by other projects.. I will try to fix this in Axis2 again, or
exclude them from the Synapse build which will just make its pom larger :(
thanks
asankha
> On Tue, Jan 13, 2009 at 19:03, <as...@apache.org> wrote:
>
>> Author: asankha
>> Date: Tue Jan 13 10:02:54 2009
>> New Revision: 734201
>>
>> URL: http://svn.apache.org/viewvc?rev=734201&view=rev
>> Log:
>> make transport dependencies valid only for the testing scope in maven
>>
--
Asankha C. Perera
http://adroitlogic.org
http://esbmagic.blogspot.com
Re: svn commit: r734201 - in /webservices/axis2/trunk/java/modules: addressing/pom.xml saaj/pom.xml
Posted by Andreas Veithen <an...@gmail.com>.
Asankha,
I had to revert this change (and the previous one) because they cause
the Axis2 build to fail (not in the modules you changed, but in
modules depending on those, e.g. jaxws and metadata).
Andreas
On Tue, Jan 13, 2009 at 19:03, <as...@apache.org> wrote:
> Author: asankha
> Date: Tue Jan 13 10:02:54 2009
> New Revision: 734201
>
> URL: http://svn.apache.org/viewvc?rev=734201&view=rev
> Log:
> make transport dependencies valid only for the testing scope in maven
>
> Modified:
> webservices/axis2/trunk/java/modules/addressing/pom.xml
> webservices/axis2/trunk/java/modules/saaj/pom.xml
>
> Modified: webservices/axis2/trunk/java/modules/addressing/pom.xml
> URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/addressing/pom.xml?rev=734201&r1=734200&r2=734201&view=diff
> ==============================================================================
> --- webservices/axis2/trunk/java/modules/addressing/pom.xml (original)
> +++ webservices/axis2/trunk/java/modules/addressing/pom.xml Tue Jan 13 10:02:54 2009
> @@ -41,14 +41,17 @@
> <dependency>
> <groupId>${project.groupId}</groupId>
> <artifactId>axis2-transport-http</artifactId>
> + <scope>test</scope>
> </dependency>
> <dependency>
> <groupId>${project.groupId}</groupId>
> <artifactId>axis2-transport-tcp</artifactId>
> + <scope>test</scope>
> </dependency>
> <dependency>
> <groupId>${project.groupId}</groupId>
> <artifactId>axis2-transport-local</artifactId>
> + <scope>test</scope>
> </dependency>
> </dependencies>
> <build>
>
> Modified: webservices/axis2/trunk/java/modules/saaj/pom.xml
> URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/saaj/pom.xml?rev=734201&r1=734200&r2=734201&view=diff
> ==============================================================================
> --- webservices/axis2/trunk/java/modules/saaj/pom.xml (original)
> +++ webservices/axis2/trunk/java/modules/saaj/pom.xml Tue Jan 13 10:02:54 2009
> @@ -45,14 +45,17 @@
> <dependency>
> <groupId>${project.groupId}</groupId>
> <artifactId>axis2-transport-http</artifactId>
> + <scope>test</scope>
> </dependency>
> <dependency>
> <groupId>${project.groupId}</groupId>
> <artifactId>axis2-transport-tcp</artifactId>
> + <scope>test</scope>
> </dependency>
> <dependency>
> <groupId>${project.groupId}</groupId>
> <artifactId>axis2-transport-local</artifactId>
> + <scope>test</scope>
> </dependency>
> <dependency>
> <groupId>org.apache.axis2</groupId>
>
>
>