[GitHub] [superset] diegomedina248 commented on pull request #20058: fix: Support the Clipboard API in modern browsers

[GitBox <gi...@apache.org>]

diegomedina248 commented on PR #20058:
URL: https://github.com/apache/superset/pull/20058#issuecomment-1132354065

   > @diegomedina248 Hi, It looks like the copy will still be called twice (send the request twice). can you check it again?
   > 
   > <img alt="image" width="1827" src="https://user-images.githubusercontent.com/11830681/168710415-6affa37f-bc6d-4946-a8e5-c42bff86d663.png">
   
   Yes, that seems to be a limitation on the API, for anything other than Safari, the promise inside `ClipboardItem` will be executed, even if it fails down the road and needs to re-execute.
   
   We could check for the browser engine and try to assign the proper clipboard api execution: That has the drawback of browser engine & version miss match, aka, not all webkit browsers behave the way Safari does (in fact, I think only Safari has this weird bug).
   We cannot reverse the condition because we cannot await anything in-between the user interaction and the clipboard api execution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org