You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "leepokai (via GitHub)" <gi...@apache.org> on 2026/07/31 15:09:55 UTC

[PR] Clarify which signal each duplicated otel_* config option applies to [airflow]

leepokai opened a new pull request, #70837:
URL: https://github.com/apache/airflow/pull/70837

   The ``otel_on``, ``otel_host``, ``otel_port``, ``otel_service``, ``otel_debugging_on`` and ``otel_ssl_active`` options appear in both the ``[metrics]`` and ``[traces]`` sections of the Configuration Reference, and their descriptions did not say which of the two features each copy configures, so users could not tell the duplicated options apart.
   
   Three descriptions were also incorrect: ``[metrics] otel_host`` and ``[metrics] otel_interval_milliseconds`` claimed to also cover traces, and ``[metrics] otel_service`` described only traces — the code reads all of these exclusively for metrics (``observability/metrics/otel_logger.py``).
   
   Each description now names the signal it configures (keeping both sets of options, per the resolution discussed in the issue), and the ``[traces]`` descriptions regain the literal markup (``True``/``False``/``config.yml``) used elsewhere so they render properly again.
   
   closes: #43366
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code, following [the Gen-AI assisted contributions guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst); all changes were verified against the code that reads these options and fully human-reviewed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Clarify which signal each duplicated otel_* config option applies to [airflow]

Posted by "leepokai (via GitHub)" <gi...@apache.org>.

leepokai commented on PR #70837:
URL: https://github.com/apache/airflow/pull/70837#issuecomment-5163273735

   Closing this — I won't be able to follow up on it. Sorry for the noise.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Clarify which signal each duplicated otel_* config option applies to [airflow]

Posted by "leepokai (via GitHub)" <gi...@apache.org>.

leepokai closed pull request #70837: Clarify which signal each duplicated otel_* config option applies to
URL: https://github.com/apache/airflow/pull/70837


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Clarify which signal each duplicated otel_* config option applies to [airflow]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.

boring-cyborg[bot] commented on PR #70837:
URL: https://github.com/apache/airflow/pull/70837#issuecomment-5144394062

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org