[GitHub] [tomcat] rmannibucau commented on a diff in pull request #501: Support max http request header size and max http header size configuration separation

[GitBox <gi...@apache.org>]

rmannibucau commented on code in PR #501:
URL: https://github.com/apache/tomcat/pull/501#discussion_r847064940


##########
java/org/apache/coyote/http11/AbstractHttp11Protocol.java:
##########
@@ -244,6 +244,34 @@ public void setMaxSavePostSize(int maxSavePostSize) {
     public void setMaxHttpHeaderSize(int valueI) { maxHttpHeaderSize = valueI; }
 
 
+    /**
+     * Maximum size of the HTTP request message header.
+     */
+    private int maxHttpRequestHeaderSize = -1;

Review Comment:
   Setter should stay IMHO and set both values to the exact same one *if not already set*.
   Getter should get the max value since the consumer wants the max size and it is exactly the semantic of this method (= what is the max for request and response, only change is that before it was a single value, now it is really a max but a min is wrong IMHO).
   
   So IMHO it makes perfect sense as method for frameworks and integrators to still have this, in particular when it is linked to pooling where max is more intended than min or any value under the max.
   
   > I still insist that semantic level compatibility is more important than API level compatibility
   
   Well there are two points:
   
   1. API compat: IMHO it is not an option to break before next 10.2 or something like that
   2. semantic level is preserved and it makes sense to have this shortcut IMHO so we can solve both at once



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org