You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by "rubenada (via GitHub)" <gi...@apache.org> on 2023/07/28 08:23:41 UTC

[GitHub] [calcite] rubenada commented on pull request #3341: [CALCITE-5877] Calcite crashes with AssertionError when compiling MOD with arguments with large scales

rubenada commented on PR #3341:
URL: https://github.com/apache/calcite/pull/3341#issuecomment-1655262457

   LGTM.
   The fix looks reasonable, considering how the precision is handled just a few lines below, and it is consistent with the description on the javadoc of the method.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org