[GitHub] [incubator-superset] ktmud commented on a change in pull request #9562: Add raw number/integer option to d3 number formats

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #9562: Add raw number/integer option to d3 number formats
URL: https://github.com/apache/incubator-superset/pull/9562#discussion_r409926324
 
 

 ##########
 File path: superset-frontend/src/explore/controls.jsx
 ##########
 @@ -83,6 +83,8 @@ export const PRIMARY_COLOR = { r: 0, g: 122, b: 135, a: 1 };
 // input choices & options
 export const D3_FORMAT_OPTIONS = [
   ['SMART_NUMBER', 'Adaptative formating'],
+  [' ', 'Original number'],
+  [',d', ',d (12345.432 => 12,345)'],
 
 Review comment:
   Some languages uses "," for decimal points, so it's probably better for i18n by being more specific.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org