[jira] [Commented] (CALCITE-1192) Document protobuf and json REP types with examples

["Francis Chuang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244943#comment-15244943 ] 

Francis Chuang commented on CALCITE-1192:
-----------------------------------------

That looks great! For the bytes_value field, I believe it should be bytes_values as per https://github.com/apache/calcite/blob/master/avatica/core/src/main/protobuf/common.proto#L199

Also, I think it would be useful to have some notes regarding the time values, for example:

- Date is the number of days since 1/1/1970.
- Time is the number of milliseconds since 00:00:00:000
- Timestamp is the number of milliseconds since 1/1/1970 00:00:00:000

> Document protobuf and json REP types with examples
> --------------------------------------------------
>
>                 Key: CALCITE-1192
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1192
>             Project: Calcite
>          Issue Type: Improvement
>          Components: avatica
>            Reporter: Francis Chuang
>            Assignee: Josh Elser
>             Fix For: avatica-1.8.0
>
>
> It would be nice to have the documentation for the Rep types here (https://calcite.apache.org/docs/avatica_protobuf_reference.html#rep) documented with examples to show what the serialized representation looks like.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)