You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@metamodel.apache.org by kaspersorensen <gi...@git.apache.org> on 2016/04/21 19:02:25 UTC

[GitHub] metamodel pull request: METAMODEL-225: Fixed

GitHub user kaspersorensen opened a pull request:

    https://github.com/apache/metamodel/pull/95

    METAMODEL-225: Fixed

    Fixes METAMODEL-225 which is about nested JSON objects in ElasticSearch responses over the REST protocol.
    
    I built this branch as a continuation of the METAMODEL-235 branch, so please first review the PR for that:
    https://github.com/apache/metamodel/pull/94

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kaspersorensen/metamodel METAMODEL-225

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metamodel/pull/95.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #95
    
----
commit 6a669d7fb2190c6349f386f38c2bb515b7b80bfe
Author: kaspersorensen <i....@gmail.com>
Date:   2016-04-21T16:44:37Z

    METAMODEL-235: Fixed

commit c5a233a65ce67d782d281e7c7e57dc425c184a19
Author: kaspersorensen <i....@gmail.com>
Date:   2016-04-21T17:00:37Z

    METAMODEL-225: Fixed

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metamodel pull request: METAMODEL-225: Fixed

Posted by kaspersorensen <gi...@git.apache.org>.

Github user kaspersorensen commented on the pull request:

    https://github.com/apache/metamodel/pull/95#issuecomment-213058448
  
    But there are a few new unittests, did you notice those? (can be hard because the diff is towards master).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metamodel pull request: METAMODEL-225: Fixed

Posted by LosD <gi...@git.apache.org>.

Github user LosD commented on the pull request:

    https://github.com/apache/metamodel/pull/95#issuecomment-213042493
  
    Also LGTM. Not tested at all, though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metamodel pull request: METAMODEL-225: Fixed

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/metamodel/pull/95


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metamodel pull request: METAMODEL-225: Fixed

Posted by LosD <gi...@git.apache.org>.

Github user LosD commented on the pull request:

    https://github.com/apache/metamodel/pull/95#issuecomment-213075177
  
    Nono, I just meant _I_ didn't test it :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---