You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2014/05/04 17:12:15 UTC

[jira] [Commented] (LUCENE-5628) SpecialOperations.getFiniteStrings should not recurse

    [ https://issues.apache.org/jira/browse/LUCENE-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13989010#comment-13989010 ] 

Robert Muir commented on LUCENE-5628:
-------------------------------------

OK i agree this is simpler.

Can we remove the "a.removeDeadTransitions()" in the test? If this is really needed for the method to work, i think it should call it...

> SpecialOperations.getFiniteStrings should not recurse
> -----------------------------------------------------
>
>                 Key: LUCENE-5628
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5628
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 4.9, 5.0
>
>         Attachments: LUCENE-5628.patch, LUCENE-5628.patch, LUCENE-5628.patch, LUCENE-5628.patch
>
>
> Today it consumes one Java stack frame per transition, which when used by AnalyzingSuggester is per character in each token.  This can lead to stack overflows if you have a long suggestion.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org