[jira] [Commented] (HBASE-10164) Allow heapsize of different units to be passed as HBASE_HEAPSIZE

["Ted Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13848496#comment-13848496 ] 

Ted Yu commented on HBASE-10164:
--------------------------------

Tried the following commands with patch - they all succeeded:
{code}
 1010  HBASE_HEAPSIZE=5G /usr/lib/hbase/bin/hbase shell
 1011  HBASE_HEAPSIZE=50m /usr/lib/hbase/bin/hbase shell
 1013  HBASE_HEAPSIZE=50 /usr/lib/hbase/bin/hbase shell
{code}

> Allow heapsize of different units to be passed as HBASE_HEAPSIZE
> ----------------------------------------------------------------
>
>                 Key: HBASE-10164
>                 URL: https://issues.apache.org/jira/browse/HBASE-10164
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>         Attachments: 10164-v1.txt
>
>
> Currently HBASE_HEAPSIZE doesn't expect units.
> {code}
> $ HBASE_HEAPSIZE=5G /usr/lib/hbase/bin/hbase shell
> Invalid maximum heap size: -Xmx5Gm
> Error: Could not create the Java Virtual Machine.
> Error: A fatal exception has occurred. Program will exit.
> {code}
> It would be more user friendly if different units of heapsize can be passed through HBASE_HEAPSIZE
> If unit ('m' or 'G') is specified, 'm' doesn't need to be appended.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)