You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/04/15 11:02:42 UTC

[GitHub] [cloudstack] DaanHoogland opened a new pull request #4030: some minor changes to make the build run with python 3

DaanHoogland opened a new pull request #4030: some minor changes to make the build run with python 3
URL: https://github.com/apache/cloudstack/pull/4030
 
 
   ## Description
   <!--- Describe your changes in detail -->
   print as method
   async keyword use in variable name fixed
   urllib openurl from urllib2 to urllib.request
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] nvazquez edited a comment on issue #4030: some minor changes to make the build run with python 3

Posted by GitBox <gi...@apache.org>.
nvazquez edited a comment on issue #4030: some minor changes to make the build run with python 3
URL: https://github.com/apache/cloudstack/pull/4030#issuecomment-614112046
 
 
   @DaanHoogland in my tests compile and run works fine, but I'm having this problem with the marvin deploy script:
   
   ````
   $  python tools/marvin/marvin/deployDataCenter.py -i ../adv-kvm.cfg
     File "tools/marvin/marvin/deployDataCenter.py", line 77
       print "\n=== Data Center Settings are dumped to %s===" % dc_file_path
                                                            ^
   SyntaxError: Missing parentheses in call to 'print'. Did you mean print("\n=== Data Center Settings are dumped to %s===" % dc_file_path)?
   ````

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] nvazquez commented on issue #4030: some minor changes to make the build run with python 3

Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #4030: some minor changes to make the build run with python 3
URL: https://github.com/apache/cloudstack/pull/4030#issuecomment-614129444
 
 
   This will need refactor in many places, maybe considering this library? https://docs.python.org/2/library/2to3.html

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] nvazquez commented on issue #4030: some minor changes to make the build run with python 3

Posted by GitBox <gi...@apache.org>.
nvazquez commented on issue #4030: some minor changes to make the build run with python 3
URL: https://github.com/apache/cloudstack/pull/4030#issuecomment-614112046
 
 
   @DaanHoogland in my tests compile works fine, but I'm having this problem with the deploy script:
   
   ````
   $  python tools/marvin/marvin/deployDataCenter.py -i ../adv-kvm.cfg
     File "tools/marvin/marvin/deployDataCenter.py", line 77
       print "\n=== Data Center Settings are dumped to %s===" % dc_file_path
                                                            ^
   SyntaxError: Missing parentheses in call to 'print'. Did you mean print("\n=== Data Center Settings are dumped to %s===" % dc_file_path)?
   ````

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on issue #4030: some minor changes to make the build run with python 3

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #4030: some minor changes to make the build run with python 3
URL: https://github.com/apache/cloudstack/pull/4030#issuecomment-614601663
 
 
   yes @nvazquez this only addresses the build. There is another PR out for python3 changes (#3730 by @GabrielBrascher) for the system vm. I don't want to merge, as this is kind of independent. I did hit that deploy script as well, we can put that in a separate PR. or here as well, i just want to move this quickly and smaller chunks move faster ;)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services