You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/07/02 11:45:08 UTC
[GitHub] [echarts] villebro opened a new pull request #15283: fix(treemap): remove old nodes on disabled animation
villebro opened a new pull request #15283:
URL: https://github.com/apache/echarts/pull/15283
When `animation` is set to `false` on `treemap`, `renderFinally()` isn't called.
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
This PR adds a call to `renderFinally()` if animation is disabled before returning from `_doAnimation`.
### Fixed issues
- closes #15282
## Details
### Before: What was the problem?
In this screenshot, Alexia and Beth should have been removed:
### After: How is it fixed in this PR?
After the change, the names are removed correctly:
### Merging options
- [x] Please squash the commits into a single one when merge.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #15283: fix(treemap): remove old nodes on disabled animation
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #15283:
URL: https://github.com/apache/echarts/pull/15283#issuecomment-872936464
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #15283: fix(treemap): remove old nodes on disabled animation
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #15283:
URL: https://github.com/apache/echarts/pull/15283#issuecomment-873355539
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] villebro closed pull request #15283: fix(treemap): remove old nodes on disabled animation
Posted by GitBox <gi...@apache.org>.
villebro closed pull request #15283:
URL: https://github.com/apache/echarts/pull/15283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang merged pull request #15283: fix(treemap): remove old nodes on disabled animation
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #15283:
URL: https://github.com/apache/echarts/pull/15283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org