You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2016/11/21 16:28:00 UTC
zeppelin git commit: [ZEPPELIN-1623] Fix flaky test -
ParagraphActionsIT.testEditOnDoubleClick
Repository: zeppelin
Updated Branches:
refs/heads/master 8aad9ea39 -> f6995738a
[ZEPPELIN-1623] Fix flaky test - ParagraphActionsIT.testEditOnDoubleClick
### What is this PR for?
Fix flaky test - ParagraphActionsIT.testEditOnDoubleClick
Before send the keyevent, make sure textarea is displayed.
### What type of PR is it?
Bug Fix
### Todos
* [x] - wait for textarea ready
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1623
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: Lee moon soo <mo...@apache.org>
Closes #1657 from Leemoonsoo/ZEPPELIN-1623 and squashes the following commits:
6ff9d44 [Lee moon soo] Wait until textarea available
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/f6995738
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/f6995738
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/f6995738
Branch: refs/heads/master
Commit: f6995738af66846417d630219ed22beacb11923f
Parents: 8aad9ea
Author: Lee moon soo <mo...@apache.org>
Authored: Fri Nov 18 10:01:05 2016 -0800
Committer: Lee moon soo <mo...@apache.org>
Committed: Mon Nov 21 08:27:56 2016 -0800
----------------------------------------------------------------------
.../java/org/apache/zeppelin/integration/ParagraphActionsIT.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/f6995738/zeppelin-server/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java
----------------------------------------------------------------------
diff --git a/zeppelin-server/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java b/zeppelin-server/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java
index 3ea63e3..6cf46ec 100644
--- a/zeppelin-server/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java
+++ b/zeppelin-server/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java
@@ -439,7 +439,7 @@ public class ParagraphActionsIT extends AbstractZeppelinIT {
Actions action = new Actions(driver);
waitForParagraph(1, "READY");
-
+ pollingWait(By.xpath(getParagraphXPath(1) + "//textarea"), MAX_PARAGRAPH_TIMEOUT_SEC);
driver.findElement(By.xpath(getParagraphXPath(1) + "//textarea")).sendKeys(Keys.SHIFT + "5");
driver.findElement(By.xpath(getParagraphXPath(1) + "//textarea")).sendKeys("md" + Keys.ENTER);
driver.findElement(By.xpath(getParagraphXPath(1) + "//textarea")).sendKeys(Keys.SHIFT + "3");