You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/04/12 10:36:58 UTC
[GitHub] [camel] essobedo opened a new pull request, #7418: CAMEL-17945: Force waiting before checking the asserts of the mock
essobedo opened a new pull request, #7418:
URL: https://github.com/apache/camel/pull/7418
Fix for https://issues.apache.org/jira/browse/CAMEL-17945
## Motivation
While working on [CAMEL-17921](https://issues.apache.org/jira/browse/CAMEL-17921), I noticed that the test `HazelcastSedaTransferExchangeTest` was unstable and should be fixed.
## Modifications
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on a diff in pull request #7418: CAMEL-17945: Force waiting before checking the asserts of the mock
Posted by GitBox <gi...@apache.org>.
orpiske commented on code in PR #7418:
URL: https://github.com/apache/camel/pull/7418#discussion_r848329488
##########
.github/workflows/master-pr-build.yml:
##########
@@ -71,14 +71,14 @@ jobs:
distribution: 'temurin'
java-version: ${{ matrix.java }}
cache: 'maven'
- - name: maven build
- run: ${{ steps.install-mvnd.outputs.mvnd-dir }}/mvnd -l build.log -Dmvnd.threads=2 -V -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120 --no-transfer-progress -Pfastinstall -Dcheckstyle.skip=true -DskipTests install
- - name: archive logs
- uses: actions/upload-artifact@v3
- if: always()
- with:
- name: build.log
- path: build.log
+# - name: maven build
+# run: ${{ steps.install-mvnd.outputs.mvnd-dir }}/mvnd -l build.log -Dmvnd.threads=2 -V -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120 --no-transfer-progress -Pfastinstall -Dcheckstyle.skip=true -DskipTests install
+# - name: archive logs
+# uses: actions/upload-artifact@v3
+# if: always()
+# with:
+# name: build.log
+# path: build.log
Review Comment:
This is preventing the build logs from being uploaded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on a diff in pull request #7418: CAMEL-17945: Force waiting before checking the asserts of the mock
Posted by GitBox <gi...@apache.org>.
essobedo commented on code in PR #7418:
URL: https://github.com/apache/camel/pull/7418#discussion_r848379760
##########
.github/workflows/master-pr-build.yml:
##########
@@ -71,14 +71,14 @@ jobs:
distribution: 'temurin'
java-version: ${{ matrix.java }}
cache: 'maven'
- - name: maven build
- run: ${{ steps.install-mvnd.outputs.mvnd-dir }}/mvnd -l build.log -Dmvnd.threads=2 -V -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120 --no-transfer-progress -Pfastinstall -Dcheckstyle.skip=true -DskipTests install
- - name: archive logs
- uses: actions/upload-artifact@v3
- if: always()
- with:
- name: build.log
- path: build.log
+# - name: maven build
+# run: ${{ steps.install-mvnd.outputs.mvnd-dir }}/mvnd -l build.log -Dmvnd.threads=2 -V -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120 --no-transfer-progress -Pfastinstall -Dcheckstyle.skip=true -DskipTests install
+# - name: archive logs
+# uses: actions/upload-artifact@v3
+# if: always()
+# with:
+# name: build.log
+# path: build.log
Review Comment:
I know, it is only to get a quick feedback (avoid waiting for the maven build) as the commit message states. I will of course remove this commit once the quick test will pass, sorry for the noise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #7418: CAMEL-17945: Force waiting before checking the asserts of the mock
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7418:
URL: https://github.com/apache/camel/pull/7418#issuecomment-1096559415
:x: Finished component verification: **1 component(s) test failed** out of 3 component(s) tested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo commented on pull request #7418: CAMEL-17945: Fix the unstable test HazelcastSedaTransferExchangeTest
Posted by GitBox <gi...@apache.org>.
essobedo commented on PR #7418:
URL: https://github.com/apache/camel/pull/7418#issuecomment-1096822154
Waiting for https://github.com/apache/camel/pull/7420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] essobedo merged pull request #7418: CAMEL-17945: Fix the unstable test HazelcastSedaTransferExchangeTest
Posted by GitBox <gi...@apache.org>.
essobedo merged PR #7418:
URL: https://github.com/apache/camel/pull/7418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #7418: CAMEL-17945: Force waiting before checking the asserts of the mock
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7418:
URL: https://github.com/apache/camel/pull/7418#issuecomment-1096551420
:warning: This PR changes Camel components and will be tested automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #7418: CAMEL-17945: Fix the unstable test HazelcastSedaTransferExchangeTest
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7418:
URL: https://github.com/apache/camel/pull/7418#issuecomment-1096878151
There are too many components to be tested in this PR, components were removed or the code needs a rebase: (23 likely to be tested)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on a diff in pull request #7418: CAMEL-17945: Force waiting before checking the asserts of the mock
Posted by GitBox <gi...@apache.org>.
orpiske commented on code in PR #7418:
URL: https://github.com/apache/camel/pull/7418#discussion_r848389844
##########
.github/workflows/master-pr-build.yml:
##########
@@ -71,14 +71,14 @@ jobs:
distribution: 'temurin'
java-version: ${{ matrix.java }}
cache: 'maven'
- - name: maven build
- run: ${{ steps.install-mvnd.outputs.mvnd-dir }}/mvnd -l build.log -Dmvnd.threads=2 -V -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120 --no-transfer-progress -Pfastinstall -Dcheckstyle.skip=true -DskipTests install
- - name: archive logs
- uses: actions/upload-artifact@v3
- if: always()
- with:
- name: build.log
- path: build.log
+# - name: maven build
+# run: ${{ steps.install-mvnd.outputs.mvnd-dir }}/mvnd -l build.log -Dmvnd.threads=2 -V -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120 --no-transfer-progress -Pfastinstall -Dcheckstyle.skip=true -DskipTests install
+# - name: archive logs
+# uses: actions/upload-artifact@v3
+# if: always()
+# with:
+# name: build.log
+# path: build.log
Review Comment:
No worries, thanks for the heads up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #7418: CAMEL-17945: Fix the unstable test HazelcastSedaTransferExchangeTest
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7418:
URL: https://github.com/apache/camel/pull/7418#issuecomment-1096820144
There are too many components to be tested in this PR, components were removed or the code needs a rebase: (23 likely to be tested)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org