[jira] [Commented] (HBASE-15174) Client Public API should not have PB objects in 2.0

["Enis Soztutar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15226778#comment-15226778 ] 

Enis Soztutar commented on HBASE-15174:
---------------------------------------

[~ram_krish] I was thinking that we can write a unit test for this so that it does not happen again. The unit test can get the public method signatures of all InterfaceAudience.Public classes and make sure that return values or arguments are not PB. Something like TestInterfaceAudienceAnnotations. wdyt?  

> Client Public API should not have PB objects in 2.0
> ---------------------------------------------------
>
>                 Key: HBASE-15174
>                 URL: https://issues.apache.org/jira/browse/HBASE-15174
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Blocker
>             Fix For: 2.0.0
>
>
> Some more cleanup for the parent jira. 
> We have leaked some PB structs in Admin (and possible other places). 
> We should clean up these API before 2.0.
> Examples include: 
> {code}
>   AdminProtos.GetRegionInfoResponse.CompactionState getCompactionState(final TableName tableName)
>     throws IOException;
>    
>     ....
>   void snapshot(final String snapshotName,
>       final TableName tableName,
>       HBaseProtos.SnapshotDescription.Type type) throws IOException, SnapshotCreationException,
>       IllegalArgumentException;
>    ....
>   MasterProtos.SnapshotResponse takeSnapshotAsync(HBaseProtos.SnapshotDescription snapshot)
>       throws IOException, SnapshotCreationException;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)