[jira] [Commented] (CRUNCH-446) Add null checks for DoFn fields

["Josh Wills (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CRUNCH-446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14064582#comment-14064582 ] 

Josh Wills commented on CRUNCH-446:
-----------------------------------

Hey Alan-- my only real nit is on the getCounter checks: if we're doing a getCounter and returning null, aren't we just pushing the NPE around a bit, vs. the other changes (like in setStatus or increment), where no NPE of any kind will likely happen?

> Add null checks for DoFn fields
> -------------------------------
>
>                 Key: CRUNCH-446
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-446
>             Project: Crunch
>          Issue Type: Improvement
>            Reporter: Allan Shoup
>            Priority: Minor
>         Attachments: CRUNCH-446.patch
>
>
> DoFn.getConfiguration() gracefully handles the fields being null, but most other methods do not. Adding null checks around all field access within DoFn would make it easier for consumers to write tests for their own function classes because they would not be required to set the context, for instance.



--
This message was sent by Atlassian JIRA
(v6.2#6252)