You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Ittay Dror (JIRA)" <ji...@apache.org> on 2008/11/06 08:51:44 UTC

[jira] Created: (BUILDR-205) resources.target is not triggered when required

resources.target is not triggered when required
-----------------------------------------------

                 Key: BUILDR-205
                 URL: https://issues.apache.org/jira/browse/BUILDR-205
             Project: Buildr
          Issue Type: Bug
    Affects Versions: 1.3.4
            Reporter: Ittay Dror
             Fix For: 1.3.4


resources.target is filter.target which is:
file(File.expand_path(dir.to_s)) { |task| run if target == task }

the problem is that since the file target has no dependencies, it is not triggered if the directory exist.

a change can be:
def @target.needed? 
   return true
end   


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (BUILDR-205) resources.target is not triggered when required

Posted by "Assaf Arkin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645598#action_12645598 ] 

Assaf Arkin commented on BUILDR-205:
------------------------------------

Fix in head.

> resources.target is not triggered when required
> -----------------------------------------------
>
>                 Key: BUILDR-205
>                 URL: https://issues.apache.org/jira/browse/BUILDR-205
>             Project: Buildr
>          Issue Type: Bug
>    Affects Versions: 1.3.4
>            Reporter: Ittay Dror
>             Fix For: 1.3.4
>
>
> resources.target is filter.target which is:
> file(File.expand_path(dir.to_s)) { |task| run if target == task }
> the problem is that since the file target has no dependencies, it is not triggered if the directory exist.
> a change can be:
> def @target.needed? 
>    return true
> end   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (BUILDR-205) resources.target is not triggered when required

Posted by "Assaf Arkin (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645598#action_12645598 ] 

assafarkin edited comment on BUILDR-205 at 11/7/08 7:50 AM:
-------------------------------------------------------------

Will have to wait for a better filter implementation, maybe FilterTask.

      was (Author: assafarkin):
    Fix in head.
  
> resources.target is not triggered when required
> -----------------------------------------------
>
>                 Key: BUILDR-205
>                 URL: https://issues.apache.org/jira/browse/BUILDR-205
>             Project: Buildr
>          Issue Type: Bug
>    Affects Versions: 1.3.4
>            Reporter: Ittay Dror
>             Fix For: 1.3.4
>
>
> resources.target is filter.target which is:
> file(File.expand_path(dir.to_s)) { |task| run if target == task }
> the problem is that since the file target has no dependencies, it is not triggered if the directory exist.
> a change can be:
> def @target.needed? 
>    return true
> end   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (BUILDR-205) resources.target is not triggered when required

Posted by "Ittay Dror (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667198#action_12667198 ] 

Ittay Dror commented on BUILDR-205:
-----------------------------------

this is easy to fix:
class Filter
    def into(dir)
      @target = file(File.expand_path(dir.to_s) => task('force')) { |task| run if target == task }
      self
    end
  end

(just added dependency on a 'force' task)

> resources.target is not triggered when required
> -----------------------------------------------
>
>                 Key: BUILDR-205
>                 URL: https://issues.apache.org/jira/browse/BUILDR-205
>             Project: Buildr
>          Issue Type: Bug
>    Affects Versions: 1.3.4
>            Reporter: Ittay Dror
>             Fix For: 1.3.4
>
>
> resources.target is filter.target which is:
> file(File.expand_path(dir.to_s)) { |task| run if target == task }
> the problem is that since the file target has no dependencies, it is not triggered if the directory exist.
> a change can be:
> def @target.needed? 
>    return true
> end   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.