You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@linkis.apache.org by GitBox <gi...@apache.org> on 2021/12/09 13:21:10 UTC

[GitHub] [incubator-linkis] peacewong opened a new issue #1177: Optimize Orchestrator to add more retry exception logic when applying for EC from AM

peacewong opened a new issue #1177:
URL: https://github.com/apache/incubator-linkis/issues/1177


   **Is your feature request related to a problem? Please describe.**
   During the stress test of Orchestrator, it is found that Orchestrator will cause various socket exceptions when applying for EC from AM. It is recommended to optimize the retry exception.
   
   **Describe the solution you'd like**
   When applying for an engine to am, change the connection exception such as socket to retry exception.
   The exception list is as follows:
   ```
   private def getEngineNodeAskManager(engineAskRequest: EngineAskRequest, mark: Mark): EngineNode = {
       val response = Utils.tryCatch(getManagerSender().ask(engineAskRequest)) { t: Throwable =>
           val baseMsg = s"mark ${mark.getMarkId()}  failed to ask linkis Manager Can be retried "
           ExceptionUtils.getRootCause(t) match {
             case socketTimeoutException: SocketTimeoutException =>
               val msg = baseMsg + ExceptionUtils.getRootCauseMessage(t)
               throw new LinkisRetryException(ECMPluginConf.ECM_ENGNE_CREATION_ERROR_CODE, msg)
             case socketException: SocketException =>
               val msg = baseMsg + ExceptionUtils.getRootCauseMessage(t)
               throw new LinkisRetryException(ECMPluginConf.ECM_ENGNE_CREATION_ERROR_CODE, msg)
             case connectException: ConnectException =>
               val msg = baseMsg + ExceptionUtils.getRootCauseMessage(t)
               throw new LinkisRetryException(ECMPluginConf.ECM_ENGNE_CREATION_ERROR_CODE, msg)
             case _ =>
               throw t
           }
       }
   ```
   
   **Describe alternatives you've considered**
   In the case of high concurrency, it is possible that the connection is abnormal, and it should be retried
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org


[GitHub] [incubator-linkis] peacewong closed issue #1177: Optimize Orchestrator to add more retry exception logic when applying for EC from AM

Posted by GitBox <gi...@apache.org>.
peacewong closed issue #1177:
URL: https://github.com/apache/incubator-linkis/issues/1177


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org


[GitHub] [incubator-linkis] peacewong commented on issue #1177: Optimize Orchestrator to add more retry exception logic when applying for EC from AM

Posted by GitBox <gi...@apache.org>.
peacewong commented on issue #1177:
URL: https://github.com/apache/incubator-linkis/issues/1177#issuecomment-989857182


   I will deal with this issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org