You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/03/02 02:56:46 UTC

[GitHub] [shardingsphere] RaigorJiang opened a new issue #15733: [OpenForce 2022] Add SQL parser test case for `ResetScalingStatement`

RaigorJiang opened a new issue #15733:
URL: https://github.com/apache/shardingsphere/issues/15733


   Hi community,
   
   This issue is for [OpenForce 2022](https://github.com/apache/shardingsphere/discussions/12683#discussioncomment-2139441)
   
   
   ### Background
   
   `RESET SCALING jobId` is a syntax in [DistSQL RAL](https://shardingsphere.apache.org/document/current/en/user-manual/shardingsphere-proxy/distsql/syntax/ral/), when `ShardingSphereSQLParserEngine` receives this SQL text, it parses it as `ResetScalingStatement`. Now we need to add a test case for this parsing process to assert that its parsing is correct.
   
   
   ### Aim
   
   Add SQL parser test case for `ResetScalingStatement`.
   
   - Affected files:
   
     - `SQLParserTestCases` (modify)
   
     - `shardingsphere-test/shardingsphere-parser-test/src/main/resources/case/ral/update.xml` (modify)
   
     - `shardingsphere-test/shardingsphere-parser-test/src/main/resources/sql/supported/ral/update.xml` (modify)
   
     - `shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/jaxb/cases/domain/statement/distsql/ral/scaling/ResetScalingStatementTestCase.java` (create)
   
     - `shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/ral/impl/scaling/update/ResetScalingStatementAssert.java` (create)
   
     - `UpdatableScalingRALStatementAssert` (modify)
   
   
   - After all, execute `DistSQLParserParameterizedTest#assertDistSQL()` for validation
   
   ### Basic Qualifications
   
   - Java
   - Maven
   
   
   ### Example FYI
   
   - `ApplyScalingStatement`
   - `ApplyScalingStatementTestCase`
   - `ApplyScalingStatementAssert`
   - search for "apply-scaling"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] pparthenhs commented on issue #15733: [OpenForce 2022] Add SQL parser test case for `ResetScalingStatement`

Posted by GitBox <gi...@apache.org>.
pparthenhs commented on issue #15733:
URL: https://github.com/apache/shardingsphere/issues/15733#issuecomment-1056597164


   Hello @RaigorJiang,
   
   Totally I would like to participate in this issue.
   
   Please let me know if I followed the correct process. Also, I remain at your disposal for any Code Review comments
   
   Best regards,
   Panagiotis Parthenis


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang edited a comment on issue #15733: [OpenForce 2022] Add SQL parser test case for `ResetScalingStatement`

Posted by GitBox <gi...@apache.org>.
RaigorJiang edited a comment on issue #15733:
URL: https://github.com/apache/shardingsphere/issues/15733#issuecomment-1056453158


   Hi @pparthenhs 
   Thank you for your interest in ShardingSphere, do you want to participate in this issue?
   I will try my best to help if needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] pparthenhs commented on issue #15733: [OpenForce 2022] Add SQL parser test case for `ResetScalingStatement`

Posted by GitBox <gi...@apache.org>.
pparthenhs commented on issue #15733:
URL: https://github.com/apache/shardingsphere/issues/15733#issuecomment-1056419508


   Dear @Raigor, 
   
   My name is Panagiotis Parthenis and I am a software engineer. I would like to put my knowledge to good use and contribute to an open-source project. 
   
   This is my first try !!! 
   
   I will try my best to offer something valuable to the community. 
   
   I remain always at your disposal.
   
   Best regards, 
   Panagiotis Parthenis


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] pparthenhs edited a comment on issue #15733: [OpenForce 2022] Add SQL parser test case for `ResetScalingStatement`

Posted by GitBox <gi...@apache.org>.
pparthenhs edited a comment on issue #15733:
URL: https://github.com/apache/shardingsphere/issues/15733#issuecomment-1056597164


   Hello @RaigorJiang,
   
   Totally I would like to participate in this issue.
   
   Please let me know if I followed the correct process. Also, I remain at your disposal for any Code Review comments
   
   Best regards,
   Panagiotis Parthenis
   
   > FYI please let me know about the slack workspace in order to join on ShardingSphere community


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on issue #15733: [OpenForce 2022] Add SQL parser test case for `ResetScalingStatement`

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #15733:
URL: https://github.com/apache/shardingsphere/issues/15733#issuecomment-1056453158


   Hi @pparthenhs 
   Thank you for your interest in ShardingSpherer, do you want to participate in this issue?
   I will try my best to help if needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on issue #15733: [OpenForce 2022] Add SQL parser test case for `ResetScalingStatement`

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #15733:
URL: https://github.com/apache/shardingsphere/issues/15733#issuecomment-1056609743


   slack: https://apacheshardingsphere.slack.com/archives/C026MLH7F34


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang closed issue #15733: [OpenForce 2022] Add SQL parser test case for `ResetScalingStatement`

Posted by GitBox <gi...@apache.org>.
RaigorJiang closed issue #15733:
URL: https://github.com/apache/shardingsphere/issues/15733


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org