You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/04/26 01:49:52 UTC
[GitHub] [shardingsphere] DreamSaddle opened a new issue #10191: Throw exception message error
DreamSaddle opened a new issue #10191:
URL: https://github.com/apache/shardingsphere/issues/10191
In file [JDBCLockEngine#checkTableLock](https://github.com/apache/shardingsphere/blob/master/shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/executor/JDBCLockEngine.java#L106) missing `String.format()`.
```java
private void checkTableLock(final ShardingSphereLock lock, final Collection<String> tableNames) throws SQLException {
for (String tableName : tableNames) {
if (lock.isLocked(LockNameUtil.getTableLockName(DefaultSchema.LOGIC_NAME, tableName))) {
// Missing format
throw new SQLException("Table %s is locked");
}
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] DreamSaddle commented on issue #10191: Throw exception message error
Posted by GitBox <gi...@apache.org>.
DreamSaddle commented on issue #10191:
URL: https://github.com/apache/shardingsphere/issues/10191#issuecomment-826482306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] DreamSaddle commented on issue #10191: Throw exception message error
Posted by GitBox <gi...@apache.org>.
DreamSaddle commented on issue #10191:
URL: https://github.com/apache/shardingsphere/issues/10191#issuecomment-826482306
Yes, it would be my pleasure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #10191: Throw exception message error
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #10191:
URL: https://github.com/apache/shardingsphere/issues/10191#issuecomment-826455935
@DreamSaddle Thank you, would you like to make a PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #10191: Throw exception message error
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #10191:
URL: https://github.com/apache/shardingsphere/issues/10191#issuecomment-826455935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #10191: Throw exception message error
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #10191:
URL: https://github.com/apache/shardingsphere/issues/10191#issuecomment-826482977
Welcome :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] DreamSaddle removed a comment on issue #10191: Throw exception message error
Posted by GitBox <gi...@apache.org>.
DreamSaddle removed a comment on issue #10191:
URL: https://github.com/apache/shardingsphere/issues/10191#issuecomment-826482306
Yes, it would be my pleasure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] DreamSaddle removed a comment on issue #10191: Throw exception message error
Posted by GitBox <gi...@apache.org>.
DreamSaddle removed a comment on issue #10191:
URL: https://github.com/apache/shardingsphere/issues/10191#issuecomment-826482306
Yes, it would be my pleasure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu closed issue #10191: Throw exception message error
Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #10191:
URL: https://github.com/apache/shardingsphere/issues/10191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] DreamSaddle commented on issue #10191: Throw exception message error
Posted by GitBox <gi...@apache.org>.
DreamSaddle commented on issue #10191:
URL: https://github.com/apache/shardingsphere/issues/10191#issuecomment-826482363
@RaigorJiang Yes, it would be my pleasure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org