You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/03/04 02:27:40 UTC

[GitHub] [dubbo-go] pherzheyu opened a new pull request #1773: Doc: more readable document

pherzheyu opened a new pull request #1773:
URL: https://github.com/apache/dubbo-go/pull/1773


   <!--  Thanks for sending a pull request!
   Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
   -->
   
   **What this PR does**: 
   1. Update some comment refers for https://dubbo-go.yuque.com/staff-ow02hm/hmg12h/isxeki.
   2. Add some package comment for document extracting of godoc.
   3. Fix some incorrect comment so the document is more readable.
   
   **Which issue(s) this PR fixes**: 
   Fixes #1755
   
   **You should pay attention to items below to ensure your pr passes our ci test**
   We do not merge pr with ci tests failed
   
   - [ ] All ut passed (run 'go test ./...' in project root)
   - [ ] After go-fmt ed , run 'go fmt project' using goland.
   - [ ] Golangci-lint passed, run 'sudo golangci-lint run' in project root.
   - [ ] After import formatted, (using [imports-formatter](https://github.com/dubbogo/tools#5-how-to-get-imports-formatter) to run 'imports-formatter .' in project root, to format your import blocks, mentioned in [CONTRIBUTING.md](https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md) above) 
   - [ ] Your new-created file needs to have [apache license](https://raw.githubusercontent.com/dubbogo/resources/master/tools/license/license.txt) at the top, like other existed file does.
   - [ ] All integration test passed. You can run integration test locally (with docker env). Clone our [dubbo-go-samples](https://github.com/apache/dubbo-go-samples) project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] Mulavar commented on a change in pull request #1773: Doc: more readable document

Posted by GitBox <gi...@apache.org>.
Mulavar commented on a change in pull request #1773:
URL: https://github.com/apache/dubbo-go/pull/1773#discussion_r827582921



##########
File path: common/rpc_service.go
##########
@@ -37,15 +37,14 @@ import (
 // RPCService the type alias of interface{}
 type RPCService = interface{}
 
-// ReferencedRPCService
-// rpc service interface
+// ReferencedRPCService is the rpc service interface which wraps base Reference method.
+//
+// Reference method refers rpc service id or reference id.

Review comment:
       this line is a method comment, it should better be placed before the method Reerence()?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] Lvnszn commented on a change in pull request #1773: Doc: more readable document

Posted by GitBox <gi...@apache.org>.
Lvnszn commented on a change in pull request #1773:
URL: https://github.com/apache/dubbo-go/pull/1773#discussion_r826853978



##########
File path: common/constant/version.go
##########
@@ -18,10 +18,7 @@
 package constant
 
 const (
-	// Version apache/dubbo-go version
-	Version = "3.0.0"
-	// Name module name
-	Name = "dubbogo"
-	// Date release date
-	DATE = "2021/05/14"
+	Version = "3.0.0"      // apache/dubbo-go version
+	Name    = "dubbogo"    // module name
+	DATE    = "2021/05/14" //release date

Review comment:
       少了个空格




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks merged pull request #1773: Doc: more readable document

Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #1773:
URL: https://github.com/apache/dubbo-go/pull/1773


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter commented on pull request #1773: Doc: more readable document

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1773:
URL: https://github.com/apache/dubbo-go/pull/1773#issuecomment-1066043282


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1773?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1773](https://codecov.io/gh/apache/dubbo-go/pull/1773?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (088b380) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/dfe4424f4dd2776148e4a43f0103f691bbe8eaee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dfe4424) will **increase** coverage by `0.09%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1773/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1773?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              3.0    #1773      +/-   ##
   ==========================================
   + Coverage   47.61%   47.71%   +0.09%     
   ==========================================
     Files         262      262              
     Lines       15098    15098              
   ==========================================
   + Hits         7189     7204      +15     
   + Misses       7123     7108      -15     
     Partials      786      786              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1773?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [cluster/cluster/base/cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyL2Jhc2UvY2x1c3Rlcl9pbnZva2VyLmdv) | `24.44% <ø> (ø)` | |
   | [common/config/environment.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2NvbmZpZy9lbnZpcm9ubWVudC5nbw==) | `70.00% <ø> (ø)` | |
   | [common/extension/metadata\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlLmdv) | `0.00% <ø> (ø)` | |
   | [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `87.43% <ø> (ø)` | |
   | [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3VybC5nbw==) | `61.12% <ø> (ø)` | |
   | [config/config\_loader\_options.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXJfb3B0aW9ucy5nbw==) | `71.96% <ø> (ø)` | |
   | [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `24.13% <ø> (ø)` | |
   | [config/registry\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZ2lzdHJ5X2NvbmZpZy5nbw==) | `84.34% <ø> (ø)` | |
   | [config/root\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Jvb3RfY29uZmlnLmdv) | `69.63% <ø> (ø)` | |
   | [config/router\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JvdXRlcl9jb25maWcuZ28=) | `77.19% <ø> (ø)` | |
   | ... and [57 more](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1773?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1773?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dfe4424...088b380](https://codecov.io/gh/apache/dubbo-go/pull/1773?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] Mulavar commented on a change in pull request #1773: Doc: more readable document

Posted by GitBox <gi...@apache.org>.
Mulavar commented on a change in pull request #1773:
URL: https://github.com/apache/dubbo-go/pull/1773#discussion_r827581660



##########
File path: common/constant/time.go
##########
@@ -21,6 +21,6 @@ import (
 	"time"
 )
 
-// The value will be 10^6
+// MsToNanoRate  will be 10^6

Review comment:
       combine two lines into one?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] pherzheyu commented on a change in pull request #1773: Doc: more readable document

Posted by GitBox <gi...@apache.org>.
pherzheyu commented on a change in pull request #1773:
URL: https://github.com/apache/dubbo-go/pull/1773#discussion_r828788472



##########
File path: common/constant/time.go
##########
@@ -21,6 +21,6 @@ import (
 	"time"
 )
 
-// The value will be 10^6
+// MsToNanoRate  will be 10^6

Review comment:
       已修改




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] Lvnszn commented on a change in pull request #1773: Doc: more readable document

Posted by GitBox <gi...@apache.org>.
Lvnszn commented on a change in pull request #1773:
URL: https://github.com/apache/dubbo-go/pull/1773#discussion_r826852820



##########
File path: common/constant/key.go
##########
@@ -291,62 +290,42 @@ const (
 
 // Use for router module
 const (
-	// TagRouterRuleSuffix Specify tag router suffix
-	TagRouterRuleSuffix = ".tag-router"
-	// ConditionRouterRuleSuffix Specify condition router suffix
-	ConditionRouterRuleSuffix = ".condition-router"
-	// MeshRouteSuffix Specify mesh router suffix
-	MeshRouteSuffix = ".MESHAPPRULE"
-	// ForceUseTag is the tag in attachment
-	ForceUseTag = "dubbo.force.tag"
-	Tagkey      = "dubbo.tag"
-	// AttachmentKey in context in invoker
-	AttachmentKey       = DubboCtxKey("attachment")
-	TagRouterFactoryKey = "tag"
-	V3RouterFactoryKey  = "mesh"
+	TagRouterRuleSuffix       = ".tag-router"             // Specify tag router suffix
+	ConditionRouterRuleSuffix = ".condition-router"       // Specify condition router suffix
+	MeshRouteSuffix           = ".MESHAPPRULE"            // Specify mesh router suffix
+	ForceUseTag               = "dubbo.force.tag"         // the tag in attachment
+	Tagkey                    = "dubbo.tag"               //  key of tag

Review comment:
       多了个 空格




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1773: Doc: more readable document

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1773:
URL: https://github.com/apache/dubbo-go/pull/1773#issuecomment-1066043282


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1773?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1773](https://codecov.io/gh/apache/dubbo-go/pull/1773?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (088b380) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/dfe4424f4dd2776148e4a43f0103f691bbe8eaee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dfe4424) will **increase** coverage by `0.09%`.
   > The diff coverage is `0.00%`.
   
   > :exclamation: Current head 088b380 differs from pull request most recent head a926315. Consider uploading reports for the commit a926315 to get more accurate results
   
   ```diff
   @@            Coverage Diff             @@
   ##              3.0    #1773      +/-   ##
   ==========================================
   + Coverage   47.61%   47.71%   +0.09%     
   ==========================================
     Files         262      262              
     Lines       15098    15098              
   ==========================================
   + Hits         7189     7204      +15     
   + Misses       7123     7108      -15     
     Partials      786      786              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1773?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [cluster/cluster/base/cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyL2Jhc2UvY2x1c3Rlcl9pbnZva2VyLmdv) | `24.44% <ø> (ø)` | |
   | [common/config/environment.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2NvbmZpZy9lbnZpcm9ubWVudC5nbw==) | `70.00% <ø> (ø)` | |
   | [common/extension/metadata\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlLmdv) | `0.00% <ø> (ø)` | |
   | [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `87.43% <ø> (ø)` | |
   | [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3VybC5nbw==) | `61.12% <ø> (ø)` | |
   | [config/config\_loader\_options.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXJfb3B0aW9ucy5nbw==) | `71.96% <ø> (ø)` | |
   | [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `24.13% <ø> (ø)` | |
   | [config/registry\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZ2lzdHJ5X2NvbmZpZy5nbw==) | `84.34% <ø> (ø)` | |
   | [config/root\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Jvb3RfY29uZmlnLmdv) | `69.63% <ø> (ø)` | |
   | [config/router\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JvdXRlcl9jb25maWcuZ28=) | `77.19% <ø> (ø)` | |
   | ... and [57 more](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1773?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1773?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dfe4424...a926315](https://codecov.io/gh/apache/dubbo-go/pull/1773?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] pherzheyu commented on a change in pull request #1773: Doc: more readable document

Posted by GitBox <gi...@apache.org>.
pherzheyu commented on a change in pull request #1773:
URL: https://github.com/apache/dubbo-go/pull/1773#discussion_r828788561



##########
File path: common/constant/version.go
##########
@@ -18,10 +18,7 @@
 package constant
 
 const (
-	// Version apache/dubbo-go version
-	Version = "3.0.0"
-	// Name module name
-	Name = "dubbogo"
-	// Date release date
-	DATE = "2021/05/14"
+	Version = "3.0.0"      // apache/dubbo-go version
+	Name    = "dubbogo"    // module name
+	DATE    = "2021/05/14" //release date

Review comment:
       已修改

##########
File path: common/constant/key.go
##########
@@ -291,62 +290,42 @@ const (
 
 // Use for router module
 const (
-	// TagRouterRuleSuffix Specify tag router suffix
-	TagRouterRuleSuffix = ".tag-router"
-	// ConditionRouterRuleSuffix Specify condition router suffix
-	ConditionRouterRuleSuffix = ".condition-router"
-	// MeshRouteSuffix Specify mesh router suffix
-	MeshRouteSuffix = ".MESHAPPRULE"
-	// ForceUseTag is the tag in attachment
-	ForceUseTag = "dubbo.force.tag"
-	Tagkey      = "dubbo.tag"
-	// AttachmentKey in context in invoker
-	AttachmentKey       = DubboCtxKey("attachment")
-	TagRouterFactoryKey = "tag"
-	V3RouterFactoryKey  = "mesh"
+	TagRouterRuleSuffix       = ".tag-router"             // Specify tag router suffix
+	ConditionRouterRuleSuffix = ".condition-router"       // Specify condition router suffix
+	MeshRouteSuffix           = ".MESHAPPRULE"            // Specify mesh router suffix
+	ForceUseTag               = "dubbo.force.tag"         // the tag in attachment
+	Tagkey                    = "dubbo.tag"               //  key of tag

Review comment:
       已修改




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #1773: Doc: more readable document

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #1773:
URL: https://github.com/apache/dubbo-go/pull/1773#discussion_r820068320



##########
File path: common/url.go
##########
@@ -48,24 +48,17 @@ import (
 
 // dubbo role type constant
 const (
-	// CONSUMER is consumer role
 	CONSUMER = iota
-	// CONFIGURATOR is configurator role
 	CONFIGURATOR
-	// ROUTER is router role

Review comment:
       why delete such comments?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1773: Doc: more readable document

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1773:
URL: https://github.com/apache/dubbo-go/pull/1773#issuecomment-1066043282


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1773?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1773](https://codecov.io/gh/apache/dubbo-go/pull/1773?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (088b380) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/dfe4424f4dd2776148e4a43f0103f691bbe8eaee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dfe4424) will **increase** coverage by `0.09%`.
   > The diff coverage is `0.00%`.
   
   > :exclamation: Current head 088b380 differs from pull request most recent head be7b3ff. Consider uploading reports for the commit be7b3ff to get more accurate results
   
   ```diff
   @@            Coverage Diff             @@
   ##              3.0    #1773      +/-   ##
   ==========================================
   + Coverage   47.61%   47.71%   +0.09%     
   ==========================================
     Files         262      262              
     Lines       15098    15098              
   ==========================================
   + Hits         7189     7204      +15     
   + Misses       7123     7108      -15     
     Partials      786      786              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1773?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [cluster/cluster/base/cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyL2Jhc2UvY2x1c3Rlcl9pbnZva2VyLmdv) | `24.44% <ø> (ø)` | |
   | [common/config/environment.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2NvbmZpZy9lbnZpcm9ubWVudC5nbw==) | `70.00% <ø> (ø)` | |
   | [common/extension/metadata\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlLmdv) | `0.00% <ø> (ø)` | |
   | [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `87.43% <ø> (ø)` | |
   | [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3VybC5nbw==) | `61.12% <ø> (ø)` | |
   | [config/config\_loader\_options.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXJfb3B0aW9ucy5nbw==) | `71.96% <ø> (ø)` | |
   | [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `24.13% <ø> (ø)` | |
   | [config/registry\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZ2lzdHJ5X2NvbmZpZy5nbw==) | `84.34% <ø> (ø)` | |
   | [config/root\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Jvb3RfY29uZmlnLmdv) | `69.63% <ø> (ø)` | |
   | [config/router\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JvdXRlcl9jb25maWcuZ28=) | `77.19% <ø> (ø)` | |
   | ... and [57 more](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1773?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1773?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dfe4424...be7b3ff](https://codecov.io/gh/apache/dubbo-go/pull/1773?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] pherzheyu commented on a change in pull request #1773: Doc: more readable document

Posted by GitBox <gi...@apache.org>.
pherzheyu commented on a change in pull request #1773:
URL: https://github.com/apache/dubbo-go/pull/1773#discussion_r828790124



##########
File path: common/rpc_service.go
##########
@@ -37,15 +37,14 @@ import (
 // RPCService the type alias of interface{}
 type RPCService = interface{}
 
-// ReferencedRPCService
-// rpc service interface
+// ReferencedRPCService is the rpc service interface which wraps base Reference method.
+//
+// Reference method refers rpc service id or reference id.

Review comment:
       ![image](https://user-images.githubusercontent.com/99853473/158748132-0aa21a8c-f44e-461a-b698-81f34e2daa47.png)
   
   It is also better to be consistent with the official interface code style.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1773: Doc: more readable document

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1773:
URL: https://github.com/apache/dubbo-go/pull/1773#issuecomment-1066043282


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1773?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1773](https://codecov.io/gh/apache/dubbo-go/pull/1773?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (088b380) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/dfe4424f4dd2776148e4a43f0103f691bbe8eaee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dfe4424) will **increase** coverage by `0.09%`.
   > The diff coverage is `0.00%`.
   
   > :exclamation: Current head 088b380 differs from pull request most recent head 3cb45bb. Consider uploading reports for the commit 3cb45bb to get more accurate results
   
   ```diff
   @@            Coverage Diff             @@
   ##              3.0    #1773      +/-   ##
   ==========================================
   + Coverage   47.61%   47.71%   +0.09%     
   ==========================================
     Files         262      262              
     Lines       15098    15098              
   ==========================================
   + Hits         7189     7204      +15     
   + Misses       7123     7108      -15     
     Partials      786      786              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1773?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [cluster/cluster/base/cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyL2Jhc2UvY2x1c3Rlcl9pbnZva2VyLmdv) | `24.44% <ø> (ø)` | |
   | [common/config/environment.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2NvbmZpZy9lbnZpcm9ubWVudC5nbw==) | `70.00% <ø> (ø)` | |
   | [common/extension/metadata\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlLmdv) | `0.00% <ø> (ø)` | |
   | [common/rpc\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3JwY19zZXJ2aWNlLmdv) | `87.43% <ø> (ø)` | |
   | [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3VybC5nbw==) | `61.12% <ø> (ø)` | |
   | [config/config\_loader\_options.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXJfb3B0aW9ucy5nbw==) | `71.96% <ø> (ø)` | |
   | [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `24.13% <ø> (ø)` | |
   | [config/registry\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZ2lzdHJ5X2NvbmZpZy5nbw==) | `84.34% <ø> (ø)` | |
   | [config/root\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Jvb3RfY29uZmlnLmdv) | `69.63% <ø> (ø)` | |
   | [config/router\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JvdXRlcl9jb25maWcuZ28=) | `77.19% <ø> (ø)` | |
   | ... and [57 more](https://codecov.io/gh/apache/dubbo-go/pull/1773/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1773?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1773?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dfe4424...3cb45bb](https://codecov.io/gh/apache/dubbo-go/pull/1773?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org