You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/01/02 19:48:04 UTC
[GitHub] vanzin commented on issue #23429: [WIP][SPARK-26432][CORE] Not able
to connect Hbase 2.x.x service Getting NoSuchMethodException while trying
to obtain token from Hbase 2.x.x service
vanzin commented on issue #23429: [WIP][SPARK-26432][CORE] Not able to connect Hbase 2.x.x service Getting NoSuchMethodException while trying to obtain token from Hbase 2.x.x service
URL: https://github.com/apache/spark/pull/23429#issuecomment-450965345
Does your code keep support for HBase 1.x? Looks like it does not; that's the main reason why I just didn't submit my patch for this:
https://github.com/cloudera/spark/commit/3de80e469211797a099798e8bbe2b1fba74ff3df#diff-6e15cee083da1fefc4b9fa8a1f8642e9
It should be easy to keep both by just keeping the existing code in a different method, can calling that one if the 2.x method fails.
Also, please use the PR title to explain the solution, not the problem. Problems are described in the bug, not the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org