[GitHub] [rocketmq] Jason918 commented on a change in pull request #3373: [ISSUE #3371]Part D: Add ak and ck stats to broker stats manager

[GitBox <gi...@apache.org>]

Jason918 commented on a change in pull request #3373:
URL: https://github.com/apache/rocketmq/pull/3373#discussion_r721853500



##########
File path: broker/src/main/java/org/apache/rocketmq/broker/processor/PopBufferMergeService.java
##########
@@ -536,6 +537,12 @@ private void putCkToStore(final PopCheckPointWrapper pointWrapper, final boolean
             POP_LOGGER.error("[PopBuffer]put ck to store fail: {}, {}", pointWrapper, putMessageResult);
             return;
         }
+        
+        this.brokerController.getBrokerStatsManager().incTopicPutNums(TopicValidator.RMQ_SYS_SCHEDULE_TOPIC, putMessageResult.getAppendMessageResult().getMsgNum(), 1);

Review comment:
       And it's duplicated codes, it's better to put these codes into a new method in BrokerStatsManager?

##########
File path: broker/src/main/java/org/apache/rocketmq/broker/processor/AckMessageProcessor.java
##########
@@ -181,6 +182,11 @@ private RemotingCommand processRequest(final Channel channel, RemotingCommand re
             && putMessageResult.getPutMessageStatus() != PutMessageStatus.FLUSH_SLAVE_TIMEOUT
             && putMessageResult.getPutMessageStatus() != PutMessageStatus.SLAVE_NOT_AVAILABLE) {
             POP_LOGGER.error("put ack msg error:" + putMessageResult);
+        } else {
+            this.brokerController.getBrokerStatsManager().incTopicPutNums(TopicValidator.RMQ_SYS_SCHEDULE_TOPIC, putMessageResult.getAppendMessageResult().getMsgNum(), 1);

Review comment:
       This line is too long, please pay attention to the code format.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org