You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/20 02:12:51 UTC
[GitHub] [spark] Yikun opened a new pull request #34335: [SPARK-36348][TEST] Complete test_astype for index
Yikun opened a new pull request #34335:
URL: https://github.com/apache/spark/pull/34335
### What changes were proposed in this pull request?
Before 3.2, there was a bug:
```
pidx = pd.Index([10, 20, 15, 30, 45, None], name="x")
psidx = ps.Index(pidx)
self.assert_eq(psidx.astype(str), pidx.astype(str))
[left pandas on spark]: Index(['10.0', '20.0', '15.0', '30.0', '45.0', 'nan'], dtype='object', name='x')
[right pandas]: Index(['10', '20', '15', '30', '45', 'None'], dtype='object', name='x')
```
So, we didn't add any test on [test_base.py int_with_nan]https://github.com/apache/spark/blob/bcc595c112a23d8e3024ace50f0dbc7eab7144b2/python/pyspark/pandas/tests/indexes/test_base.py#L2249
Now, the bug had been resolved, we complete the testcase in here.
### Why are the changes needed?
regression for SPARK-36348 and complete testcase.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Test only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34335: [SPARK-36348][TEST] Complete test_astype for index
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34335:
URL: https://github.com/apache/spark/pull/34335#issuecomment-947283585
**[Test build #144436 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144436/testReport)** for PR 34335 at commit [`a8607e1`](https://github.com/apache/spark/commit/a8607e1a0b3c46fe8fa9d261e11ab5e4414b95c6).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34335: [SPARK-36348][TEST] Complete test_astype for index
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34335:
URL: https://github.com/apache/spark/pull/34335#issuecomment-947297388
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144436/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34335: [SPARK-36348][TEST] Complete test_astype for index
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34335:
URL: https://github.com/apache/spark/pull/34335#issuecomment-947315625
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48909/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34335: [SPARK-36348][TEST] Complete test_astype for index
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34335:
URL: https://github.com/apache/spark/pull/34335#issuecomment-947270315
**[Test build #144436 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144436/testReport)** for PR 34335 at commit [`a8607e1`](https://github.com/apache/spark/commit/a8607e1a0b3c46fe8fa9d261e11ab5e4414b95c6).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34335: [SPARK-36348][TEST] Complete test_astype for index
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34335:
URL: https://github.com/apache/spark/pull/34335#issuecomment-947286989
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48909/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34335: [SPARK-36348][TEST] Complete test_astype for index
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34335:
URL: https://github.com/apache/spark/pull/34335#issuecomment-947270315
**[Test build #144436 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144436/testReport)** for PR 34335 at commit [`a8607e1`](https://github.com/apache/spark/commit/a8607e1a0b3c46fe8fa9d261e11ab5e4414b95c6).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34335: [SPARK-36348][TEST] Complete test_astype for index
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34335:
URL: https://github.com/apache/spark/pull/34335#issuecomment-947297388
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144436/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34335: [SPARK-36348][TEST] Complete test_astype for index
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34335:
URL: https://github.com/apache/spark/pull/34335#issuecomment-947284440
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34335: [SPARK-36348][TEST] Complete test_astype for index
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34335:
URL: https://github.com/apache/spark/pull/34335#issuecomment-947322680
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48909/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #34335: [SPARK-36348][TEST] Complete test_astype for index
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34335:
URL: https://github.com/apache/spark/pull/34335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34335: [SPARK-36348][TEST] Complete test_astype for index
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34335:
URL: https://github.com/apache/spark/pull/34335#issuecomment-947322680
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48909/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org