You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/28 12:51:30 UTC
[GitHub] [flink] zentol opened a new pull request #10954:
[FLINK-15785][travis][e2e] Rework E2E test activations
zentol opened a new pull request #10954: [FLINK-15785][travis][e2e] Rework E2E test activations
URL: https://github.com/apache/flink/pull/10954
This PR reworks the activation logic for java end-to-end tests.
Introduces a new framework for specifying category inclusions/exclusions in `flink-end-to-end-tests`, that is capable of automatically aggregating properties across profiles.
Inclusions are defined by setting the `e2e.include.<category-class>`, conversely exclusions by setting `e2e.exclude.<category-class>`. The value of the property is a boolean that controls whether the inclusion/exclusions is enabled or not.
A groovy script searches for all properties matching the naming scheme, extracts the category class, aggregates inclusions/exclusions and sets the appropriate properties.
**Background**: Maven does not really support combining categories. The surefire-plugin only accepts values like `catA,catB`, instead of a list where individual items have their own XML element. This implies that in order to combine category definitions one would have to concatenate the current value with some other value, i.e., do `categories = categories + "hello"`. Maven doesn't support this however since it is a recursive definition of a property.
The following is a listing of every problem and how it was addressed:
1) **travis activations are spread out over multiple files (.travis.yml, travis_watchdoh.sh)**
They are now consolidated in .travis.yml. While this does introduce some redundancy it is still preferable because .travis.yml is the most visible travis file, and it is easier to mvoe the pre-commit activation around.
2) **setting multiple categories in .travis.yml is incredibly verbose**
Each category now has their dedicated profile in `flink-end-to-end-tests` that set the appropriate category. This is significantly more concise and provides an abstraction of the specific categories used. (In other words, we can modify things at will without breaking setups)
3) **hadoop tests are not excluded by default**
Now disabled by default.
4) **hadoop exclusions aren't setup (causing FLINK-15685)**
Are now setup.
5) **automatic java11 exclusion is prone to not working as intended**
There is now a dedicated java11 profile in `flink-end-to-end-tests` to ensure the java11 exclusions is always applied.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10954:
[FLINK-15785][travis][e2e] Rework E2E test activations
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10954: [FLINK-15785][travis][e2e] Rework E2E test activations
URL: https://github.com/apache/flink/pull/10954#discussion_r373096880
##########
File path: flink-end-to-end-tests/pom.xml
##########
@@ -90,6 +162,66 @@ under the License.
<skip>true</skip>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.codehaus.gmavenplus</groupId>
+ <artifactId>gmavenplus-plugin</artifactId>
+ <version>1.8.1</version>
+ <dependencies>
+ <dependency>
+ <groupId>org.codehaus.groovy</groupId>
+ <artifactId>groovy-all</artifactId>
+ <version>2.5.9</version>
+ <scope>runtime</scope>
+ <type>pom</type>
+ </dependency>
+ </dependencies>
+ <executions>
+ <execution>
+ <id>merge-categories</id>
+ <phase>initialize</phase>
+ <goals>
+ <goal>execute</goal>
+ </goals>
+ <configuration>
+ <scripts>
+ <script>
+ <![CDATA[
+ def categorySearcher = { String propertyPrefix ->
+ project.properties.entrySet().stream()
+ .filter { p -> p.getKey().startsWith(propertyPrefix) }
+ .filter { p -> p.getValue().toBoolean() }
+ .map { p -> p.getKey() }
+ .map { p -> p.substring(propertyPrefix.size(), p.size()) }
+ .toList()
+ }
+
+ def includes = categorySearcher('e2e.include.')
+ // allow overrides from the command-line
+ if (!project.properties.includeE2E.isEmpty()) {
+ includes.add(project.properties.includeE2E)
+ }
+ if (includes.size() > 0) {
+ project.properties.includeE2E = includes.join(',')
+ } else {
+ project.properties.includeE2E = project.properties.'includeE2E.default'
+ }
+
+ def excludes = categorySearcher('e2e.exclude.')
+ // allow overrides from the command-line
+ if (!project.properties.excludeE2E.isEmpty()) {
+ excludes.add(project.properties.excludeE2E)
+ }
+ project.properties.excludeE2E = excludes.join(',')
+
+ println "includes: " + project.properties.includeE2E
+ println "excludes: " + project.properties.excludeE2E
Review comment:
I'm not sure. I like that you can tell at a glance whether something is off, which will be useful on Travis.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10954:
[FLINK-15785][travis][e2e] Rework E2E test activations
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10954: [FLINK-15785][travis][e2e] Rework E2E test activations
URL: https://github.com/apache/flink/pull/10954#issuecomment-579232020
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 0a4cdba97fcfbb788402b890e6e958cb2949646b (Tue Jan 28 12:54:58 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10954:
[FLINK-15785][travis][e2e] Rework E2E test activations
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10954: [FLINK-15785][travis][e2e] Rework E2E test activations
URL: https://github.com/apache/flink/pull/10954#issuecomment-579242201
<!--
Meta data
Hash:0a4cdba97fcfbb788402b890e6e958cb2949646b Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:0a4cdba97fcfbb788402b890e6e958cb2949646b
-->
## CI report:
* 0a4cdba97fcfbb788402b890e6e958cb2949646b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10954:
[FLINK-15785][travis][e2e] Rework E2E test activations
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10954: [FLINK-15785][travis][e2e] Rework E2E test activations
URL: https://github.com/apache/flink/pull/10954#issuecomment-579242201
<!--
Meta data
Hash:0a4cdba97fcfbb788402b890e6e958cb2949646b Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4638 TriggerType:PUSH TriggerID:0a4cdba97fcfbb788402b890e6e958cb2949646b
Hash:0a4cdba97fcfbb788402b890e6e958cb2949646b Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146389068 TriggerType:PUSH TriggerID:0a4cdba97fcfbb788402b890e6e958cb2949646b
Hash:73b8f36264985692b35cf2e2ddb3c619df97d299 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:73b8f36264985692b35cf2e2ddb3c619df97d299
-->
## CI report:
* 0a4cdba97fcfbb788402b890e6e958cb2949646b Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146389068) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4638)
* 73b8f36264985692b35cf2e2ddb3c619df97d299 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10954:
[FLINK-15785][travis][e2e] Rework E2E test activations
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10954: [FLINK-15785][travis][e2e] Rework E2E test activations
URL: https://github.com/apache/flink/pull/10954#discussion_r373096066
##########
File path: flink-end-to-end-tests/pom.xml
##########
@@ -35,8 +35,19 @@ under the License.
<name>flink-end-to-end-tests</name>
<properties>
- <includeE2E>org.apache.flink.tests.util.categories.Dummy</includeE2E>
- <excludeE2E></excludeE2E>
+ <includeE2E/> <!-- keep this empty -->
+ <excludeE2E/> <!-- keep this empty -->
+ <!-- functions as a global exclude; required since an empty set of included groups implicitly includes all -->
+ <includeE2E.default>org.apache.flink.tests.util.categories.Dummy</includeE2E.default>
+ <!-- default inclusions / exclusions -->
+ <e2e.include.org.apache.flink.tests.util.categories.TravisGroup1>false</e2e.include.org.apache.flink.tests.util.categories.TravisGroup1>
+ <e2e.include.org.apache.flink.tests.util.categories.TravisGroup2>false</e2e.include.org.apache.flink.tests.util.categories.TravisGroup2>
+ <e2e.include.org.apache.flink.tests.util.categories.TravisGroup3>false</e2e.include.org.apache.flink.tests.util.categories.TravisGroup3>
+ <e2e.include.org.apache.flink.tests.util.categories.TravisGroup4>false</e2e.include.org.apache.flink.tests.util.categories.TravisGroup4>
+ <e2e.include.org.apache.flink.tests.util.categories.TravisGroup5>false</e2e.include.org.apache.flink.tests.util.categories.TravisGroup5>
+ <e2e.include.org.apache.flink.tests.util.categories.TravisGroup6>false</e2e.include.org.apache.flink.tests.util.categories.TravisGroup6>
+ <e2e.exclude.org.apache.flink.tests.util.categories.Hadoop>true</e2e.exclude.org.apache.flink.tests.util.categories.Hadoop>
+ <e2e.exclude.org.apache.flink.testutils.junit.FailsOnJava11>true</e2e.exclude.org.apache.flink.testutils.junit.FailsOnJava11>
Review comment:
we can. technically it's not necessary, but it's a good idea to do so for clarity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10954:
[FLINK-15785][travis][e2e] Rework E2E test activations
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10954: [FLINK-15785][travis][e2e] Rework E2E test activations
URL: https://github.com/apache/flink/pull/10954#issuecomment-579242201
<!--
Meta data
Hash:0a4cdba97fcfbb788402b890e6e958cb2949646b Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4638 TriggerType:PUSH TriggerID:0a4cdba97fcfbb788402b890e6e958cb2949646b
Hash:0a4cdba97fcfbb788402b890e6e958cb2949646b Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146389068 TriggerType:PUSH TriggerID:0a4cdba97fcfbb788402b890e6e958cb2949646b
-->
## CI report:
* 0a4cdba97fcfbb788402b890e6e958cb2949646b Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146389068) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4638)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10954:
[FLINK-15785][travis][e2e] Rework E2E test activations
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10954: [FLINK-15785][travis][e2e] Rework E2E test activations
URL: https://github.com/apache/flink/pull/10954#discussion_r373063185
##########
File path: flink-end-to-end-tests/pom.xml
##########
@@ -90,6 +162,66 @@ under the License.
<skip>true</skip>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.codehaus.gmavenplus</groupId>
+ <artifactId>gmavenplus-plugin</artifactId>
+ <version>1.8.1</version>
+ <dependencies>
+ <dependency>
+ <groupId>org.codehaus.groovy</groupId>
+ <artifactId>groovy-all</artifactId>
+ <version>2.5.9</version>
+ <scope>runtime</scope>
+ <type>pom</type>
+ </dependency>
+ </dependencies>
+ <executions>
+ <execution>
+ <id>merge-categories</id>
+ <phase>initialize</phase>
+ <goals>
+ <goal>execute</goal>
+ </goals>
+ <configuration>
+ <scripts>
+ <script>
+ <![CDATA[
+ def categorySearcher = { String propertyPrefix ->
+ project.properties.entrySet().stream()
+ .filter { p -> p.getKey().startsWith(propertyPrefix) }
+ .filter { p -> p.getValue().toBoolean() }
+ .map { p -> p.getKey() }
+ .map { p -> p.substring(propertyPrefix.size(), p.size()) }
+ .toList()
+ }
+
+ def includes = categorySearcher('e2e.include.')
+ // allow overrides from the command-line
+ if (!project.properties.includeE2E.isEmpty()) {
+ includes.add(project.properties.includeE2E)
+ }
+ if (includes.size() > 0) {
+ project.properties.includeE2E = includes.join(',')
+ } else {
+ project.properties.includeE2E = project.properties.'includeE2E.default'
+ }
+
+ def excludes = categorySearcher('e2e.exclude.')
+ // allow overrides from the command-line
+ if (!project.properties.excludeE2E.isEmpty()) {
+ excludes.add(project.properties.excludeE2E)
+ }
+ project.properties.excludeE2E = excludes.join(',')
+
+ println "includes: " + project.properties.includeE2E
+ println "excludes: " + project.properties.excludeE2E
Review comment:
Do we want to keep these `printlns`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #10954:
[FLINK-15785][travis][e2e] Rework E2E test activations
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #10954: [FLINK-15785][travis][e2e] Rework E2E test activations
URL: https://github.com/apache/flink/pull/10954#discussion_r373058433
##########
File path: flink-end-to-end-tests/pom.xml
##########
@@ -35,8 +35,19 @@ under the License.
<name>flink-end-to-end-tests</name>
<properties>
- <includeE2E>org.apache.flink.tests.util.categories.Dummy</includeE2E>
- <excludeE2E></excludeE2E>
+ <includeE2E/> <!-- keep this empty -->
+ <excludeE2E/> <!-- keep this empty -->
+ <!-- functions as a global exclude; required since an empty set of included groups implicitly includes all -->
+ <includeE2E.default>org.apache.flink.tests.util.categories.Dummy</includeE2E.default>
+ <!-- default inclusions / exclusions -->
+ <e2e.include.org.apache.flink.tests.util.categories.TravisGroup1>false</e2e.include.org.apache.flink.tests.util.categories.TravisGroup1>
+ <e2e.include.org.apache.flink.tests.util.categories.TravisGroup2>false</e2e.include.org.apache.flink.tests.util.categories.TravisGroup2>
+ <e2e.include.org.apache.flink.tests.util.categories.TravisGroup3>false</e2e.include.org.apache.flink.tests.util.categories.TravisGroup3>
+ <e2e.include.org.apache.flink.tests.util.categories.TravisGroup4>false</e2e.include.org.apache.flink.tests.util.categories.TravisGroup4>
+ <e2e.include.org.apache.flink.tests.util.categories.TravisGroup5>false</e2e.include.org.apache.flink.tests.util.categories.TravisGroup5>
+ <e2e.include.org.apache.flink.tests.util.categories.TravisGroup6>false</e2e.include.org.apache.flink.tests.util.categories.TravisGroup6>
+ <e2e.exclude.org.apache.flink.tests.util.categories.Hadoop>true</e2e.exclude.org.apache.flink.tests.util.categories.Hadoop>
+ <e2e.exclude.org.apache.flink.testutils.junit.FailsOnJava11>true</e2e.exclude.org.apache.flink.testutils.junit.FailsOnJava11>
Review comment:
Should `<e2e.include.org.apache.flink.tests.util.categories.PreCommit>false</e2e.include.org.apache.flink.tests.util.categories.PreCommit>` be added here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10954:
[FLINK-15785][travis][e2e] Rework E2E test activations
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10954: [FLINK-15785][travis][e2e] Rework E2E test activations
URL: https://github.com/apache/flink/pull/10954#discussion_r373106382
##########
File path: flink-end-to-end-tests/pom.xml
##########
@@ -90,6 +162,66 @@ under the License.
<skip>true</skip>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.codehaus.gmavenplus</groupId>
+ <artifactId>gmavenplus-plugin</artifactId>
+ <version>1.8.1</version>
+ <dependencies>
+ <dependency>
+ <groupId>org.codehaus.groovy</groupId>
+ <artifactId>groovy-all</artifactId>
+ <version>2.5.9</version>
+ <scope>runtime</scope>
+ <type>pom</type>
+ </dependency>
+ </dependencies>
+ <executions>
+ <execution>
+ <id>merge-categories</id>
+ <phase>initialize</phase>
+ <goals>
+ <goal>execute</goal>
+ </goals>
+ <configuration>
+ <scripts>
+ <script>
+ <![CDATA[
+ def categorySearcher = { String propertyPrefix ->
+ project.properties.entrySet().stream()
+ .filter { p -> p.getKey().startsWith(propertyPrefix) }
+ .filter { p -> p.getValue().toBoolean() }
+ .map { p -> p.getKey() }
+ .map { p -> p.substring(propertyPrefix.size(), p.size()) }
+ .toList()
+ }
+
+ def includes = categorySearcher('e2e.include.')
+ // allow overrides from the command-line
+ if (!project.properties.includeE2E.isEmpty()) {
+ includes.add(project.properties.includeE2E)
+ }
+ if (includes.size() > 0) {
+ project.properties.includeE2E = includes.join(',')
+ } else {
+ project.properties.includeE2E = project.properties.'includeE2E.default'
+ }
+
+ def excludes = categorySearcher('e2e.exclude.')
+ // allow overrides from the command-line
+ if (!project.properties.excludeE2E.isEmpty()) {
+ excludes.add(project.properties.excludeE2E)
+ }
+ project.properties.excludeE2E = excludes.join(',')
+
+ println "includes: " + project.properties.includeE2E
+ println "excludes: " + project.properties.excludeE2E
Review comment:
maybe keep them for a bit until the transition to azure is done and we are confident it works as it should.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10954:
[FLINK-15785][travis][e2e] Rework E2E test activations
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10954: [FLINK-15785][travis][e2e] Rework E2E test activations
URL: https://github.com/apache/flink/pull/10954#issuecomment-579242201
<!--
Meta data
Hash:0a4cdba97fcfbb788402b890e6e958cb2949646b Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4638 TriggerType:PUSH TriggerID:0a4cdba97fcfbb788402b890e6e958cb2949646b
Hash:0a4cdba97fcfbb788402b890e6e958cb2949646b Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146389068 TriggerType:PUSH TriggerID:0a4cdba97fcfbb788402b890e6e958cb2949646b
Hash:73b8f36264985692b35cf2e2ddb3c619df97d299 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146815794 TriggerType:PUSH TriggerID:73b8f36264985692b35cf2e2ddb3c619df97d299
Hash:73b8f36264985692b35cf2e2ddb3c619df97d299 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4704 TriggerType:PUSH TriggerID:73b8f36264985692b35cf2e2ddb3c619df97d299
-->
## CI report:
* 0a4cdba97fcfbb788402b890e6e958cb2949646b Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146389068) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4638)
* 73b8f36264985692b35cf2e2ddb3c619df97d299 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146815794) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4704)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10954:
[FLINK-15785][travis][e2e] Rework E2E test activations
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10954: [FLINK-15785][travis][e2e] Rework E2E test activations
URL: https://github.com/apache/flink/pull/10954#issuecomment-579242201
<!--
Meta data
Hash:0a4cdba97fcfbb788402b890e6e958cb2949646b Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4638 TriggerType:PUSH TriggerID:0a4cdba97fcfbb788402b890e6e958cb2949646b
Hash:0a4cdba97fcfbb788402b890e6e958cb2949646b Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146389068 TriggerType:PUSH TriggerID:0a4cdba97fcfbb788402b890e6e958cb2949646b
Hash:73b8f36264985692b35cf2e2ddb3c619df97d299 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146815794 TriggerType:PUSH TriggerID:73b8f36264985692b35cf2e2ddb3c619df97d299
Hash:73b8f36264985692b35cf2e2ddb3c619df97d299 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4704 TriggerType:PUSH TriggerID:73b8f36264985692b35cf2e2ddb3c619df97d299
-->
## CI report:
* 0a4cdba97fcfbb788402b890e6e958cb2949646b Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146389068) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4638)
* 73b8f36264985692b35cf2e2ddb3c619df97d299 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146815794) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4704)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10954:
[FLINK-15785][travis][e2e] Rework E2E test activations
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10954: [FLINK-15785][travis][e2e] Rework E2E test activations
URL: https://github.com/apache/flink/pull/10954#issuecomment-579242201
<!--
Meta data
Hash:0a4cdba97fcfbb788402b890e6e958cb2949646b Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4638 TriggerType:PUSH TriggerID:0a4cdba97fcfbb788402b890e6e958cb2949646b
Hash:0a4cdba97fcfbb788402b890e6e958cb2949646b Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146389068 TriggerType:PUSH TriggerID:0a4cdba97fcfbb788402b890e6e958cb2949646b
-->
## CI report:
* 0a4cdba97fcfbb788402b890e6e958cb2949646b Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146389068) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4638)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol merged pull request #10954:
[FLINK-15785][travis][e2e] Rework E2E test activations
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #10954: [FLINK-15785][travis][e2e] Rework E2E test activations
URL: https://github.com/apache/flink/pull/10954
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #10954:
[FLINK-15785][travis][e2e] Rework E2E test activations
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10954: [FLINK-15785][travis][e2e] Rework E2E test activations
URL: https://github.com/apache/flink/pull/10954#discussion_r373134908
##########
File path: flink-end-to-end-tests/pom.xml
##########
@@ -35,8 +35,19 @@ under the License.
<name>flink-end-to-end-tests</name>
<properties>
- <includeE2E>org.apache.flink.tests.util.categories.Dummy</includeE2E>
- <excludeE2E></excludeE2E>
+ <includeE2E/> <!-- keep this empty -->
+ <excludeE2E/> <!-- keep this empty -->
+ <!-- functions as a global exclude; required since an empty set of included groups implicitly includes all -->
+ <includeE2E.default>org.apache.flink.tests.util.categories.Dummy</includeE2E.default>
+ <!-- default inclusions / exclusions -->
+ <e2e.include.org.apache.flink.tests.util.categories.TravisGroup1>false</e2e.include.org.apache.flink.tests.util.categories.TravisGroup1>
+ <e2e.include.org.apache.flink.tests.util.categories.TravisGroup2>false</e2e.include.org.apache.flink.tests.util.categories.TravisGroup2>
+ <e2e.include.org.apache.flink.tests.util.categories.TravisGroup3>false</e2e.include.org.apache.flink.tests.util.categories.TravisGroup3>
+ <e2e.include.org.apache.flink.tests.util.categories.TravisGroup4>false</e2e.include.org.apache.flink.tests.util.categories.TravisGroup4>
+ <e2e.include.org.apache.flink.tests.util.categories.TravisGroup5>false</e2e.include.org.apache.flink.tests.util.categories.TravisGroup5>
+ <e2e.include.org.apache.flink.tests.util.categories.TravisGroup6>false</e2e.include.org.apache.flink.tests.util.categories.TravisGroup6>
+ <e2e.exclude.org.apache.flink.tests.util.categories.Hadoop>true</e2e.exclude.org.apache.flink.tests.util.categories.Hadoop>
+ <e2e.exclude.org.apache.flink.testutils.junit.FailsOnJava11>true</e2e.exclude.org.apache.flink.testutils.junit.FailsOnJava11>
Review comment:
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10954:
[FLINK-15785][travis][e2e] Rework E2E test activations
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10954: [FLINK-15785][travis][e2e] Rework E2E test activations
URL: https://github.com/apache/flink/pull/10954#issuecomment-579242201
<!--
Meta data
Hash:0a4cdba97fcfbb788402b890e6e958cb2949646b Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4638 TriggerType:PUSH TriggerID:0a4cdba97fcfbb788402b890e6e958cb2949646b
Hash:0a4cdba97fcfbb788402b890e6e958cb2949646b Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/146389068 TriggerType:PUSH TriggerID:0a4cdba97fcfbb788402b890e6e958cb2949646b
-->
## CI report:
* 0a4cdba97fcfbb788402b890e6e958cb2949646b Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146389068) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4638)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services