[jira] [Commented] (WHIMSY-213) Secretary workbench message hash is not guaranteed unique or stable

["Sebb (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WHIMSY-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158542#comment-17158542 ] 

Sebb commented on WHIMSY-213:
-----------------------------

Also, if the message id is missing, the hash uses the entire message.
This includes all the headers, so will depend on the route to the host.
In particular, the host name will be included.
This makes it harder to migrate from one host to another; in particular the secretary mail database needs careful handling


> Secretary workbench message hash is not guaranteed unique or stable
> -------------------------------------------------------------------
>
>                 Key: WHIMSY-213
>                 URL: https://issues.apache.org/jira/browse/WHIMSY-213
>             Project: Whimsy
>          Issue Type: Bug
>            Reporter: Sebb
>            Priority: Major
>
> The message hash is generated here [1]. 
> This is not guaranteed unique, as some Message-ID header lines are wrapped; the unique part is on the next line. 
> Further, message IDs themselves may not be unique, though this is much less likely.
> Also AFAICT the code can pick up a Message-ID which is in the body of a message.
> If two such messages arrive in the same month, the second will replace the first.
> If the first message has not been handled, AFAICT it won't ever be processed.
> [1] https://github.com/apache/whimsy/blob/9118c9187f5dc234f5c659caf54e90a7301bb4e3/www/secretary/workbench/models/message.rb#L317



--
This message was sent by Atlassian Jira
(v8.3.4#803005)