You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/07/02 10:28:21 UTC

[GitHub] [beam] lgajowy commented on pull request #12117: [BEAM-10343] Add dispositions for SnowflakeIO.write

lgajowy commented on pull request #12117:
URL: https://github.com/apache/beam/pull/12117#issuecomment-652925396


   @purbanow I will try to take a look at that today or tomorrow. If I won't leave a review by then, please try to ping somebody else (that will mean that I did not have enough time to go through all this. :)
   
   Something that draws my attention when I scanned the code quickly (bear in mind that I might be missing some Snowflake details): why do we need to create all the SnowflakeDataTypes? Is there a way to create them in one class (without specifying all the separate types for that)? That would (probably?) make things more compact.
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org