[GitHub] [pinot] kkrugler commented on a change in pull request #7722: Skip pinot.admin.system.exit check for quickstart

[GitBox <gi...@apache.org>]

kkrugler commented on a change in pull request #7722:
URL: https://github.com/apache/pinot/pull/7722#discussion_r748782799



##########
File path: pinot-tools/src/main/java/org/apache/pinot/tools/admin/PinotAdministrator.java
##########
@@ -192,7 +192,11 @@ public static void main(String[] args) {
     PluginManager.get().init();
     PinotAdministrator pinotAdministrator = new PinotAdministrator();
     pinotAdministrator.execute(args);
-    if (System.getProperties().getProperty("pinot.admin.system.exit", "false").equalsIgnoreCase("true")) {
+    // Ignore `pinot.admin.system.exit` property for Pinot quickstarts.
+    if ((args.length > 0) && ("quickstart".equalsIgnoreCase(args[0]))) {

Review comment:
       I know I'm late to the party, but why bury a somewhat obscure raw string comparison in this code (and elsewhere), versus having the quickstart code ensure `pinot.admin.system.exit` is set to `false`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org