You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/02/20 19:31:47 UTC
Review Request 65719: Windows: Fixed CMake check of toolset for Ninja.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65719/
-----------------------------------------------------------
Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and Joseph Wu.
Bugs: MESOS-8599
https://issues.apache.org/jira/browse/MESOS-8599
Repository: mesos
Description
-------
Only the Visual Studio generator(s) should check the toolset. The
Ninja generator requires the environment to be setup in advance, and
does not have the concept of a toolset, so this warning broke the
Ninja build.
Diffs
-----
cmake/CompilationConfigure.cmake 50cddf9476c8c5196c4824a7b060c2680a96b277
Diff: https://reviews.apache.org/r/65719/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 65719: Windows: Fixed CMake configuration for
Ninja.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65719/
-----------------------------------------------------------
(Updated March 7, 2018, 1:43 p.m.)
Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and Joseph Wu.
Summary (updated)
-----------------
Windows: Fixed CMake configuration for Ninja.
Bugs: MESOS-8599
https://issues.apache.org/jira/browse/MESOS-8599
Repository: mesos
Description (updated)
-------
Only the Visual Studio generator(s) should check the toolset. The
Ninja generator requires the environment to be setup in advance, and
does not have the concept of a toolset, so this warning broke the
Ninja build.
Instead of warning that we're deprecating some arbitrary generator, we
should just say we don't officially support it so the user knows it
may not work as expected.
Fixed the assumption that all generators on Windows are
multi-configuration. Ninja is single-configuration, so the debug CRT
flag must sometimes be set for `CMAKE_CXX_FLAGS` depending on
`CMAKE_BUILD_TYPE`.
Diffs (updated)
-----
cmake/CompilationConfigure.cmake 50cddf9476c8c5196c4824a7b060c2680a96b277
Diff: https://reviews.apache.org/r/65719/diff/3/
Changes: https://reviews.apache.org/r/65719/diff/2-3/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 65719: Windows: Fixed CMake check of toolset for
Ninja.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65719/#review198781
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On March 6, 2018, 9:04 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65719/
> -----------------------------------------------------------
>
> (Updated March 6, 2018, 9:04 p.m.)
>
>
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and Joseph Wu.
>
>
> Bugs: MESOS-8599
> https://issues.apache.org/jira/browse/MESOS-8599
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Only the Visual Studio generator(s) should check the toolset. The
> Ninja generator requires the environment to be setup in advance, and
> does not have the concept of a toolset, so this warning broke the
> Ninja build.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake 50cddf9476c8c5196c4824a7b060c2680a96b277
>
>
> Diff: https://reviews.apache.org/r/65719/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 65719: Windows: Fixed CMake check of toolset for
Ninja.
Posted by Akash Gupta <ak...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65719/#review198746
-----------------------------------------------------------
Ship it!
Ship It!
- Akash Gupta
On March 6, 2018, 8:04 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65719/
> -----------------------------------------------------------
>
> (Updated March 6, 2018, 8:04 p.m.)
>
>
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and Joseph Wu.
>
>
> Bugs: MESOS-8599
> https://issues.apache.org/jira/browse/MESOS-8599
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Only the Visual Studio generator(s) should check the toolset. The
> Ninja generator requires the environment to be setup in advance, and
> does not have the concept of a toolset, so this warning broke the
> Ninja build.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake 50cddf9476c8c5196c4824a7b060c2680a96b277
>
>
> Diff: https://reviews.apache.org/r/65719/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 65719: Windows: Fixed CMake check of toolset for
Ninja.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65719/
-----------------------------------------------------------
(Updated March 6, 2018, 12:04 p.m.)
Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and Joseph Wu.
Changes
-------
Made a warning more clear.
Bugs: MESOS-8599
https://issues.apache.org/jira/browse/MESOS-8599
Repository: mesos
Description
-------
Only the Visual Studio generator(s) should check the toolset. The
Ninja generator requires the environment to be setup in advance, and
does not have the concept of a toolset, so this warning broke the
Ninja build.
Diffs (updated)
-----
cmake/CompilationConfigure.cmake 50cddf9476c8c5196c4824a7b060c2680a96b277
Diff: https://reviews.apache.org/r/65719/diff/2/
Changes: https://reviews.apache.org/r/65719/diff/1-2/
Testing
-------
Thanks,
Andrew Schwartzmeyer
Re: Review Request 65719: Windows: Fixed CMake check of toolset for
Ninja.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65719/#review197845
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On Feb. 20, 2018, 8:31 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65719/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2018, 8:31 p.m.)
>
>
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and Joseph Wu.
>
>
> Bugs: MESOS-8599
> https://issues.apache.org/jira/browse/MESOS-8599
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Only the Visual Studio generator(s) should check the toolset. The
> Ninja generator requires the environment to be setup in advance, and
> does not have the concept of a toolset, so this warning broke the
> Ninja build.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake 50cddf9476c8c5196c4824a7b060c2680a96b277
>
>
> Diff: https://reviews.apache.org/r/65719/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>