You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2023/05/25 12:44:54 UTC
[GitHub] [iceberg] Fokko opened a new pull request, #7698: Python: Refactor integration tests
Fokko opened a new pull request, #7698:
URL: https://github.com/apache/iceberg/pull/7698
This splits out running and building the integration tests that enables quick development iterations. I've also added ipython that will give a more meaningful error when something goes wrong with the provisioning of the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] danielcweeks commented on a diff in pull request #7698: Python: Refactor integration tests
Posted by "danielcweeks (via GitHub)" <gi...@apache.org>.
danielcweeks commented on code in PR #7698:
URL: https://github.com/apache/iceberg/pull/7698#discussion_r1205740604
##########
python/dev/provision.py:
##########
@@ -59,78 +44,142 @@
spark.sql(
"""
- DROP TABLE IF EXISTS test_null_nan_rewritten;
+ CREATE OR REPLACE TABLE default.test_null_nan_rewritten
+ USING iceberg
+ AS SELECT * FROM default.test_null_nan
"""
)
spark.sql(
"""
- CREATE TABLE test_null_nan_rewritten
- USING iceberg
- AS SELECT * FROM test_null_nan
+CREATE OR REPLACE TABLE default.test_limit
Review Comment:
This might be simplified to:
```sql
CREATE OR REPLACE TABLE default.test_limit as
SELECT * LATERAL VIEW explode(ARRAY(1, 2, 3, 4, 5, 6,7, 8, 9, 10)) AS idx;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko merged pull request #7698: Python: Refactor integration tests
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #7698:
URL: https://github.com/apache/iceberg/pull/7698
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on pull request #7698: Python: Refactor integration tests
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #7698:
URL: https://github.com/apache/iceberg/pull/7698#issuecomment-1563349621
Thanks @danielcweeks for the review! 👍🏻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on a diff in pull request #7698: Python: Refactor integration tests
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #7698:
URL: https://github.com/apache/iceberg/pull/7698#discussion_r1205876714
##########
python/dev/provision.py:
##########
@@ -59,78 +44,142 @@
spark.sql(
"""
- DROP TABLE IF EXISTS test_null_nan_rewritten;
+ CREATE OR REPLACE TABLE default.test_null_nan_rewritten
+ USING iceberg
+ AS SELECT * FROM default.test_null_nan
"""
)
spark.sql(
"""
- CREATE TABLE test_null_nan_rewritten
- USING iceberg
- AS SELECT * FROM test_null_nan
+CREATE OR REPLACE TABLE default.test_limit
Review Comment:
I like it, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org