You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/03/12 17:27:04 UTC

[GitHub] [pulsar] merlimat commented on a change in pull request #9876: [Metrics] Add the broker connection metrics.

merlimat commented on a change in pull request #9876:
URL: https://github.com/apache/pulsar/pull/9876#discussion_r593339758



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/BrokerOperabilityMetrics.java
##########
@@ -34,6 +35,11 @@
     private final DimensionStats zkWriteLatencyStats;
     private final DimensionStats zkReadLatencyStats;
     private final String brokerName;
+    private final AtomicLong connectionTotalCreatedCount;

Review comment:
       Prefer `LongAdder` instead of `AtomicLong` since it will have less contention issues.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org