You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "masayag (via GitHub)" <gi...@apache.org> on 2024/02/27 23:22:17 UTC
[PR] Propagate workflow labels to the its K8s resources [incubator-kie-kogito-serverless-operator]
masayag opened a new pull request, #413:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/413
**Description of the change:**
To provide an option to manage and view resources created in the workflow, all workflow labels are added to the resources associated with the workflow, created by the operator.
The default labels will override user-specified labels if provided with the same label key but with a different value than the workflow name.
**Motivation for the change:**
Fixes https://github.com/apache/incubator-kie-kogito-serverless-operator/issues/410
**Checklist**
- [x] Add or Modify a unit test for your change
- [x] Have you verified that tall the tests are passing?
<details>
<summary>
How to backport a pull request to a different branch?
</summary>
In order to automatically create a **backporting pull request** please add one or more labels having the following format `backport-<branch-name>`, where `<branch-name>` is the name of the branch where the pull request must be backported to (e.g., `backport-7.67.x` to backport the original PR to the `7.67.x` branch).
> **NOTE**: **backporting** is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.
Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.
> **NOTE**: this automated backporting is triggered whenever a pull request on `main` branch is labeled or closed, but both conditions must be satisfied to get the new PR created.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Propagate workflow labels to the its K8s resources [incubator-kie-kogito-serverless-operator]
Posted by "masayag (via GitHub)" <gi...@apache.org>.
masayag commented on PR #413:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/413#issuecomment-1978947547
@ricardozanini the PR is rebased + propagates the labels to knative resources as well. What should be done next to get it merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Propagate workflow labels to the its K8s resources [incubator-kie-kogito-serverless-operator]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on PR #413:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/413#issuecomment-1991795937
@jakubschwan @domhanak it's been a week. Can we get a review so I can merge it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Propagate workflow labels to the its K8s resources [incubator-kie-kogito-serverless-operator]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on PR #413:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/413#issuecomment-1969716972
@masayag can you do one more rebase? Since now we create knative resources, we should make sure that the labels are propagating there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Propagate workflow labels to the its K8s resources [incubator-kie-kogito-serverless-operator]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on PR #413:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/413#issuecomment-1984356643
@jakubschwan @domhanak can one of you please review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Propagate workflow labels to the its K8s resources [incubator-kie-kogito-serverless-operator]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on PR #413:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/413#issuecomment-1980940881
@masayag we will only merge after QE verification. cc @domhanak @jakubschwan can you please verify?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Propagate workflow labels to the its K8s resources [incubator-kie-kogito-serverless-operator]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on PR #413:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/413#issuecomment-1969087556
@masayag can you rebase please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] Propagate workflow labels to the its K8s resources [incubator-kie-kogito-serverless-operator]
Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini merged PR #413:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org