You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/03/07 16:12:53 UTC
[GitHub] [maven-shared-utils] I-Cat opened a new pull request #82: Up date https and added
I-Cat opened a new pull request #82:
URL: https://github.com/apache/maven-shared-utils/pull/82
updated http to https and added please.
Consider adding
Licence(s)
If more than one licence is present
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] hboutemy commented on a change in pull request #82: Up date https and added
Posted by GitBox <gi...@apache.org>.
hboutemy commented on a change in pull request #82:
URL: https://github.com/apache/maven-shared-utils/pull/82#discussion_r589054235
##########
File path: pom.xml
##########
@@ -1,23 +1,23 @@
<?xml version='1.0' encoding='UTF-8'?>
<!--
Licensed to the Apache Software Foundation (ASF) under one
- or more contributor license agreements. See the NOTICE file
+ or more contributor license agreements.Please see the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
- with the License. You may obtain a copy of the License at
+ with the License. You can obtain a copy of the License at the following link
- http://www.apache.org/licenses/LICENSE-2.0
+ https://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
- software distributed under the License is distributed on an
+ the software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- KIND, either express or implied. See the License for the
+ KIND, either express or implied. Please see the License for the
Review comment:
no you cannot change the license text like this, even if you think your wording is better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] hboutemy commented on pull request #82: Up date https and added
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #82:
URL: https://github.com/apache/maven-shared-utils/pull/82#issuecomment-792306241
sorry, closed as invalid, as per comments
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] hboutemy commented on a change in pull request #82: Up date https and added
Posted by GitBox <gi...@apache.org>.
hboutemy commented on a change in pull request #82:
URL: https://github.com/apache/maven-shared-utils/pull/82#discussion_r589054426
##########
File path: pom.xml
##########
@@ -1,23 +1,23 @@
<?xml version='1.0' encoding='UTF-8'?>
<!--
Licensed to the Apache Software Foundation (ASF) under one
- or more contributor license agreements. See the NOTICE file
+ or more contributor license agreements.Please see the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
- with the License. You may obtain a copy of the License at
+ with the License. You can obtain a copy of the License at the following link
- http://www.apache.org/licenses/LICENSE-2.0
+ https://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
- software distributed under the License is distributed on an
+ the software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- KIND, either express or implied. See the License for the
+ KIND, either express or implied. Please see the License for the
specific language governing permissions and limitations
under the License.
-->
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
Review comment:
everything you changed are identifiers, then not to change (and not really used as url to download anything)
the only url that is used to download something (= the xsd file) is the only location you did not change: this one can be changed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] hboutemy closed pull request #82: Up date https and added
Posted by GitBox <gi...@apache.org>.
hboutemy closed pull request #82:
URL: https://github.com/apache/maven-shared-utils/pull/82
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org