You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "fallintoplace (via GitHub)" <gi...@apache.org> on 2026/07/28 10:23:02 UTC
[PR] fix(arrow/scalar): use duration type for units [arrow-go]
fallintoplace opened a new pull request, #1041:
URL: https://github.com/apache/arrow-go/pull/1041
## What changed
Read a duration scalar's unit from `arrow.DurationType` instead of asserting it is a timestamp type.
## Why
Valid duration scalars carry `*arrow.DurationType`. The previous assertion to `*arrow.TimestampType` panicked whenever `Unit` was called, including through string formatting and duration unit conversion.
The regression test covers direct unit access, string formatting, and seconds-to-milliseconds conversion.
## Validation
`go test ./arrow/scalar`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(arrow/scalar): use duration type for units [arrow-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #1041:
URL: https://github.com/apache/arrow-go/pull/1041
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org