[GitHub] [spark] hvanhovell commented on a diff in pull request #41959: [SPARK-44388][CONNECT] Fix protobuf cast issue when UDF instance is updated

["hvanhovell (via GitHub)" <gi...@apache.org>]

hvanhovell commented on code in PR #41959:
URL: https://github.com/apache/spark/pull/41959#discussion_r1261585969


##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala:
##########
@@ -92,17 +92,21 @@ sealed abstract class UserDefinedFunction {
 /**
  * Holder class for a scalar user-defined function and it's input/output encoder(s).
  */
-case class ScalarUserDefinedFunction(
+case class ScalarUserDefinedFunction private (
     function: AnyRef,
     inputEncoders: Seq[AgnosticEncoder[_]],
     outputEncoder: AgnosticEncoder[_],
     name: Option[String],
     override val nullable: Boolean,
-    override val deterministic: Boolean)
+    override val deterministic: Boolean,

Review Comment:
   We could also make the serialized `udf` part of the parameters. That should make it a bit easier to work with.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org