You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "vinx13 (via GitHub)" <gi...@apache.org> on 2023/04/06 19:24:06 UTC
[GitHub] [tvm] vinx13 opened a new pull request, #14521: [TOPI] Support symbolic shape in einsum
vinx13 opened a new pull request, #14521:
URL: https://github.com/apache/tvm/pull/14521
cc @sunggg @jwfromm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 merged pull request #14521: [TOPI] Support symbolic shape in einsum
Posted by "vinx13 (via GitHub)" <gi...@apache.org>.
vinx13 merged PR #14521:
URL: https://github.com/apache/tvm/pull/14521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #14521: [TOPI] Support symbolic shape in einsum
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14521:
URL: https://github.com/apache/tvm/pull/14521#issuecomment-1499514231
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* No users to tag found in teams: `topi` <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on a diff in pull request #14521: [TOPI] Support symbolic shape in einsum
Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on code in PR #14521:
URL: https://github.com/apache/tvm/pull/14521#discussion_r1160714232
##########
src/topi/einsum.cc:
##########
@@ -98,24 +98,33 @@ EinsumEquation EinsumEquation::FromString(const std::string& equation) {
}
PrimExpr GetBroadcastedExtent(const PrimExpr& extent1, const PrimExpr& extent2) {
- int64_t extent1_value = GetConstInt(extent1);
- int64_t extent2_value = GetConstInt(extent2);
- if (extent1_value == extent2_value) {
+ const IntImmNode* extent1_imm = extent1.as<IntImmNode>();
Review Comment:
One minor note for future, would be useful to have common broadcast extent handling in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org