You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/02 16:59:55 UTC
[GitHub] [shardingsphere] jingshanglu opened a new pull request, #18161: fix autocommmit
jingshanglu opened a new pull request, #18161:
URL: https://github.com/apache/shardingsphere/pull/18161
Changes proposed in this pull request:
- In MySQL, when autocommit = 0, open a new transaction for `COM_STMT_PREPARE` pkg.
- In PostgreSQL, when autocommit = 0, open a new transaction for `BIND_COMMAND` pkg.
- In OpenGauss, when autocommit = 0, open a new transaction for `BIND_COMMAND` and `BATCH_BIND_COMMAND` pkg.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #18161: fix autocommmit
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18161:
URL: https://github.com/apache/shardingsphere/pull/18161#issuecomment-1145626733
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18161?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18161](https://codecov.io/gh/apache/shardingsphere/pull/18161?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (691df06) into [master](https://codecov.io/gh/apache/shardingsphere/commit/1b77c33983198a420e974a302d2a891ca05ae664?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1b77c33) will **decrease** coverage by `0.00%`.
> The diff coverage is `40.00%`.
> :exclamation: Current head 691df06 differs from pull request most recent head 16ded33. Consider uploading reports for the commit 16ded33 to get more accurate results
```diff
@@ Coverage Diff @@
## master #18161 +/- ##
============================================
- Coverage 59.07% 59.07% -0.01%
Complexity 2170 2170
============================================
Files 3692 3692
Lines 54362 54371 +9
Branches 9246 9247 +1
============================================
+ Hits 32117 32121 +4
- Misses 19501 19506 +5
Partials 2744 2744
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/18161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ompute/watcher/ComputeNodeStateChangedWatcher.java](https://codecov.io/gh/apache/shardingsphere/pull/18161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvY2x1c3Rlci9jb29yZGluYXRvci9yZWdpc3RyeS9zdGF0dXMvY29tcHV0ZS93YXRjaGVyL0NvbXB1dGVOb2RlU3RhdGVDaGFuZ2VkV2F0Y2hlci5qYXZh) | `30.23% <0.00%> (ø)` | |
| [...ication/jdbc/connection/JDBCBackendConnection.java](https://codecov.io/gh/apache/shardingsphere/pull/18161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvY29ubmVjdGlvbi9KREJDQmFja2VuZENvbm5lY3Rpb24uamF2YQ==) | `77.60% <0.00%> (-2.24%)` | :arrow_down: |
| [...nd/communication/vertx/VertxBackendConnection.java](https://codecov.io/gh/apache/shardingsphere/pull/18161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL3ZlcnR4L1ZlcnR4QmFja2VuZENvbm5lY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ry/binary/execute/MySQLComStmtExecuteExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/18161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL2NvbW1hbmQvcXVlcnkvYmluYXJ5L2V4ZWN1dGUvTXlTUUxDb21TdG10RXhlY3V0ZUV4ZWN1dG9yLmphdmE=) | `67.34% <0.00%> (-2.87%)` | :arrow_down: |
| [...ry/binary/prepare/MySQLComStmtPrepareExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/18161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL2NvbW1hbmQvcXVlcnkvYmluYXJ5L3ByZXBhcmUvTXlTUUxDb21TdG10UHJlcGFyZUV4ZWN1dG9yLmphdmE=) | `15.21% <0.00%> (-0.34%)` | :arrow_down: |
| [...ackend/text/TextProtocolBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/18161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L1RleHRQcm90b2NvbEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `68.85% <100.00%> (ø)` | |
| [...re/proxy/frontend/command/CommandExecutorTask.java](https://codecov.io/gh/apache/shardingsphere/pull/18161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvY29tbWFuZC9Db21tYW5kRXhlY3V0b3JUYXNrLmphdmE=) | `61.01% <100.00%> (+0.67%)` | :arrow_up: |
| [.../query/text/query/MySQLMultiStatementsHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/18161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Byb3h5L2Zyb250ZW5kL215c3FsL2NvbW1hbmQvcXVlcnkvdGV4dC9xdWVyeS9NeVNRTE11bHRpU3RhdGVtZW50c0hhbmRsZXIuamF2YQ==) | `95.89% <100.00%> (+0.05%)` | :arrow_up: |
| [...y/extended/bind/OpenGaussComBatchBindExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/18161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtb3BlbmdhdXNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9mcm9udGVuZC9vcGVuZ2F1c3MvY29tbWFuZC9xdWVyeS9leHRlbmRlZC9iaW5kL09wZW5HYXVzc0NvbUJhdGNoQmluZEV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...query/extended/bind/PostgreSQLComBindExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/18161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvcG9zdGdyZXNxbC9jb21tYW5kL3F1ZXJ5L2V4dGVuZGVkL2JpbmQvUG9zdGdyZVNRTENvbUJpbmRFeGVjdXRvci5qYXZh) | `100.00% <100.00%> (ø)` | |
| ... and [2 more](https://codecov.io/gh/apache/shardingsphere/pull/18161/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18161?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18161?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4590f50...16ded33](https://codecov.io/gh/apache/shardingsphere/pull/18161?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN merged pull request #18161: fix autocommmit
Posted by GitBox <gi...@apache.org>.
TeslaCN merged PR #18161:
URL: https://github.com/apache/shardingsphere/pull/18161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on a diff in pull request #18161: fix autocommmit
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on code in PR #18161:
URL: https://github.com/apache/shardingsphere/pull/18161#discussion_r889446114
##########
shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-opengauss/src/main/java/org/apache/shardingsphere/proxy/frontend/opengauss/command/query/extended/bind/OpenGaussComBatchBindExecutor.java:
##########
@@ -46,6 +46,7 @@ public final class OpenGaussComBatchBindExecutor implements CommandExecutor {
@Override
public Collection<DatabasePacket<?>> execute() throws SQLException {
+ connectionSession.getBackendConnection().handleAutoCommit();
Review Comment:
`PostgreSQLAggregatedBatchedStatementsCommandExecutor` also uses `PostgreSQLBatchedStatementsExecutor` to do batched statements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on a diff in pull request #18161: fix autocommmit
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on code in PR #18161:
URL: https://github.com/apache/shardingsphere/pull/18161#discussion_r888568722
##########
shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/proxy/frontend/postgresql/command/query/extended/bind/PostgreSQLComBindExecutor.java:
##########
@@ -47,6 +47,7 @@ public final class PostgreSQLComBindExecutor implements CommandExecutor {
@Override
public Collection<DatabasePacket<?>> execute() throws SQLException {
+ connectionSession.getBackendConnection().prepareForTaskExecution();
Review Comment:
There may be more than a Bind packet in a CommandExecuteTask. This may cause the `connectionReferenceCount` in JDBCBackendConnection more than 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org