You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by agamemnus <gi...@git.apache.org> on 2015/06/08 18:50:51 UTC
[GitHub] cordova-plugin-whitelist pull request: update
GitHub user agamemnus opened a pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/6
update
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/agamemnus/cordova-plugin-whitelist master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-whitelist/pull/6.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6
----
commit 0d837115dd7e55ff8d163f9e7a63d99cd009951e
Author: agamemnus <ag...@users.noreply.github.com>
Date: 2015-06-08T16:14:35Z
Update WhitelistPlugin.java
commit f322ec5e73b1fd4ee3293b699120cded4c729630
Author: agamemnus <ag...@users.noreply.github.com>
Date: 2015-06-08T16:21:27Z
Update WhitelistPlugin.java
commit 74e6e6924f6a85ed70820b29d38c153636d8b513
Author: agamemnus <ag...@users.noreply.github.com>
Date: 2015-06-08T16:22:28Z
Update WhitelistPlugin.java
commit 1cdd0883add5ed586bfe1e16347cda327f6d14f4
Author: agamemnus <ag...@users.noreply.github.com>
Date: 2015-06-08T16:24:40Z
Testing...
commit f53ef6e3b757668d11ef20f6d3dbd74809c17677
Author: agamemnus <ag...@users.noreply.github.com>
Date: 2015-06-08T16:27:27Z
Update WhitelistPlugin.java
commit 88351ec8d56088fbbb9fe5f000393a9959dae35d
Author: agamemnus <ag...@users.noreply.github.com>
Date: 2015-06-08T16:41:17Z
Update WhitelistPlugin.java
commit 7462c9bf8e7ceb3be461fd19ecf72696a3d06c38
Author: agamemnus <ag...@users.noreply.github.com>
Date: 2015-06-08T16:43:12Z
Update WhitelistPlugin.java
commit 63186220fa90c5967ecf7ee6484b5c7c50f1c699
Author: agamemnus <ag...@users.noreply.github.com>
Date: 2015-06-08T16:46:03Z
Update WhitelistPlugin.java
commit 8e70d6d406cc74ac1b04ed613a1f18dae71be18b
Author: agamemnus <ag...@users.noreply.github.com>
Date: 2015-06-08T16:48:18Z
Update WhitelistPlugin.java
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112609463
This looks good to me. I'll merge it in
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Posted by agamemnus <gi...@git.apache.org>.
Github user agamemnus commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112611004
Actually, hold on a second. The change is not quite what the title says. It only automatically whitelists ``content://``, ``cdvfile://``, and ``file://`` for ``allowedNavigations`` if there is a ``*`` origin. What do you think of adding those regardless of the origin?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Posted by agamemnus <gi...@git.apache.org>.
Github user agamemnus commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112611552
(And to be honest, I am fuzzy about what ``allowedNavigations``, ``allowedRequests``, and ``allowedIntents`` exactly mean.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Posted by agamemnus <gi...@git.apache.org>.
Github user agamemnus commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-118204964
Ok, I'll do that...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112614600
Argh, Just merged it in haha. I am going to revert it so we have more time to test. Looks like it is causing problems.
I'd say we stick with keeping it in the loop for now.
I am not super familiar with this plugin. It looks like `allowedNavigations == null` is for giving default access to `file` and `data`. I could see content fitting in there. Don't think we need cdvfile:// unless removing it breaks the file plugin for you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: update
Posted by agamemnus <gi...@git.apache.org>.
Github user agamemnus commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-111575700
Yes to both questions.
https://issues.apache.org/jira/browse/CB-9133
P.S.: If you could take a look at https://issues.apache.org/jira/browse/CB-9132 that would be nice too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Posted by agamemnus <gi...@git.apache.org>.
Github user agamemnus commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-113300176
But the Cordova Android 3 is not like that. Why the difference?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Posted by agamemnus <gi...@git.apache.org>.
Github user agamemnus commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-128927222
Reposted. https://github.com/apache/cordova-plugin-whitelist/pull/9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Posted by agamemnus <gi...@git.apache.org>.
Github user agamemnus commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112615378
It is still closed. You have to re-open it manually. (button below comment textbox)
My changes did fix the issue for me, but only because I had the origin at *.
I will read more about whitelist stuff myself and see where the best place is to put it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Posted by agamemnus <gi...@git.apache.org>.
Github user agamemnus commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-111581796
``cdvfile://`` is a protocol used in Cordova for accessing saved files: https://github.com/apache/cordova-plugin-file.
Regarding ``content://``, a little back-story which should help explain. Google Play has a 50 megabyte apk size upload limit. To go beyond that it uses an expansion file system which allows up to (I think) 2 gigabytes of extra storage. The expansion files are typically downloaded to and stored in ``Phone/Android/obb`` as zip files with 0 compression ("STORE"). To access the files Google recommends using a content provider (http://developer.android.com/guide/topics/providers/content-providers.html). (A content provider is used for a few more things, as well...)
I made a comprehensive plugin for using these expansion files here: https://github.com/agamemnus/cordova-plugin-xapkreader/. It links to and makes use of 2 Android libraries made by Google called ``play_apk_expansion`` and ``play_licensing``. A number of people wanted to use Cordova 5, but the plugin doesn't work with 5 because ant support is not supported or broken.
Unfortunately, Gradle support is somewhat broken as well as I describe in https://issues.apache.org/jira/browse/CB-9132.
Even going past the Gradle issues, the whitelist requirement in Cordova 5 means that by default ``content://`` files (the method used to access files in the zip file) are not usable. There are two fixes to this -- patching the whitelist plugin, or adding content:// in the CSP tag.
P.S.: Even with this whitelist plugin patch, I am having issues loading JPG files (but not other types of files) using the ``content://`` protocol (my Chrome debugger claims that ``content://`` protocol is unrecognized), but this may be a Chromium or Crosswalk issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-113309069
Security!
I do think it is unfortunate that *data and *file aren't on by default without the whitelist plugin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: update
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-111574764
Thanks, @agamemnus for the contribution! Do you have an Apache CLA signed? If not, please sign one http://www.apache.org/licenses/icla.txt and send it to secretary@apache.org. Do you have a JIRA for this issue you are trying to fix explaining why it needs to be fixed? If not, it will help to file one here: https://issues.apache.org/jira/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Posted by agamemnus <gi...@git.apache.org>.
Github user agamemnus commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-113284557
Can you find out why this was made mandatory in the first place? Maybe it really shouldn't be.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-113295035
Why the whitelist plugin was made mandatory?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Posted by micky2be <gi...@git.apache.org>.
Github user micky2be commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-128652022
Would love to see that PR getting in
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112617030
Sweet! Thanks. I'll take a look tonight/tomorrow and see if we can figure this out. Let me know if you come up with any findings. We may have to open a new PR :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112614830
Reverted it. Hopefully this PR opens agian
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112615358
This is a pretty big problem IMO. File plugin not working. I am going to test it to see if I can reproduce the issues. A better solution would be if the file plugin added an exception to config.xml when getting installed. Doesn't seem to be doing that right now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-111579159
I'm somewhat new to this area. What is cdvfile and content protocol used for? Does Android actually, support navigating to either. Why should one use cdvfile over file? I will follow up and document some of these aspects if you can help me understand.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112616193
Any chance you can give me some steps to reproduce it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-whitelist/pull/6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Posted by agamemnus <gi...@git.apache.org>.
Github user agamemnus commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-128678730
Today!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: update
Posted by agamemnus <gi...@git.apache.org>.
Github user agamemnus commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-111577359
Well, there are really 2 issues, sort of.
First of all, cdvfile:// and content:// should be automatically whitelisted. That's what this patch is about.
Secondly, assuming for some reason they shouldn't be automatically whitelisted (but they should), the CSP meta tag example in the readme for this plugin is not expansive enough.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Posted by agamemnus <gi...@git.apache.org>.
Github user agamemnus commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112616455
I can't re-open it. Reproduce steps would be to use any Google Expansion File plugin (like mine here, and see these steps to update to Cordova 5: https://github.com/agamemnus/cordova-plugin-xapkreader/issues/22) or use file-transfer plugin to try to add files I suppose.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-113298090
Whitelist plugin is mandatory to be able to connect to internet in the Android platform. By default, the Android 4.0 platform cannot connect to the internet.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Posted by agamemnus <gi...@git.apache.org>.
Github user agamemnus commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-113315662
Well, in a rush to engineer false sense of security, *someone* messed up big time.
Don't forget ``cdvfile://`` and ``content://``...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-112615819
I think only you or apache infra people can re-open it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: update
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-111576774
The issue you describe in the JIRA has to do with updates to the CSP and not the whitelist itself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-whitelist pull request: Automatically whitelist con...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/6#issuecomment-118203230
@agamemnus Wondering if you want to create a new PR for support for cdvfile:// and content:// ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org