You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/04 10:53:53 UTC
[GitHub] [airflow] ashb opened a new pull request #14065: Update to Pytest 6.0
ashb opened a new pull request #14065:
URL: https://github.com/apache/airflow/pull/14065
And pytest 6 removed a class that the rerunfailures plugin was using, so
we have to upgrade that too.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #14065: Update to Pytest 6.0
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #14065:
URL: https://github.com/apache/airflow/pull/14065#discussion_r570145311
##########
File path: setup.py
##########
@@ -502,10 +502,10 @@ def get_sphinx_theme_version() -> str:
'pre-commit',
'pylint==2.6.0',
'pysftp',
- 'pytest',
+ 'pytest~=6.0',
Review comment:
We are already using the latest pytest:
https://github.com/apache/airflow/blob/ae2e0275bde2e551a63e2ee9b1c56538535e7657/constraints-3.6.txt#L327
https://github.com/apache/airflow/blob/ae2e0275bde2e551a63e2ee9b1c56538535e7657/constraints-3.7.txt#L322
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14065: Update to Pytest 6.0
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14065:
URL: https://github.com/apache/airflow/pull/14065#issuecomment-773284824
Constraints file is already using this, so should be fine to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #14065: Update to Pytest 6.0
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #14065:
URL: https://github.com/apache/airflow/pull/14065#discussion_r570145311
##########
File path: setup.py
##########
@@ -502,10 +502,10 @@ def get_sphinx_theme_version() -> str:
'pre-commit',
'pylint==2.6.0',
'pysftp',
- 'pytest',
+ 'pytest~=6.0',
Review comment:
We are already using the latest pytest:
https://github.com/apache/airflow/blob/ae2e0275bde2e551a63e2ee9b1c56538535e7657/constraints-3.6.txt#L327
https://github.com/apache/airflow/blob/ae2e0275bde2e551a63e2ee9b1c56538535e7657/constraints-3.7.txt#L322
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #14065: Update to Pytest 6.0
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #14065:
URL: https://github.com/apache/airflow/pull/14065
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #14065: Update to Pytest 6.0
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #14065:
URL: https://github.com/apache/airflow/pull/14065#discussion_r570202143
##########
File path: setup.py
##########
@@ -502,10 +502,10 @@ def get_sphinx_theme_version() -> str:
'pre-commit',
'pylint==2.6.0',
'pysftp',
- 'pytest',
+ 'pytest~=6.0',
Review comment:
In constraints yes, this enforces it for anyone now using the constraint files too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14065: Update to Pytest 6.0
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14065:
URL: https://github.com/apache/airflow/pull/14065#issuecomment-773233994
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #14065: Update to Pytest 6.0
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #14065:
URL: https://github.com/apache/airflow/pull/14065
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #14065: Update to Pytest 6.0
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #14065:
URL: https://github.com/apache/airflow/pull/14065#discussion_r570202143
##########
File path: setup.py
##########
@@ -502,10 +502,10 @@ def get_sphinx_theme_version() -> str:
'pre-commit',
'pylint==2.6.0',
'pysftp',
- 'pytest',
+ 'pytest~=6.0',
Review comment:
In constraints yes, this enforces it for anyone now using the constraint files too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14065: Update to Pytest 6.0
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14065:
URL: https://github.com/apache/airflow/pull/14065#issuecomment-773233994
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14065: Update to Pytest 6.0
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14065:
URL: https://github.com/apache/airflow/pull/14065#issuecomment-773222181
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #14065: Update to Pytest 6.0
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #14065:
URL: https://github.com/apache/airflow/pull/14065#issuecomment-773222181
Lets see if full suite passes here -- I tested a few things locally and didn't notice any problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org