You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jason Huynh <jh...@pivotal.io> on 2016/09/08 22:26:39 UTC
Review Request 51735: GEODE-1840: Certain map queries combine OR
predicates into an AND junction
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51735/
-----------------------------------------------------------
Review request for geode, Barry Oglesby and nabarun nag.
Repository: geode
Description
-------
When deciding whether to combine the predicates into a common junction, the type should be checked to make sure they are the same. This will prevent OR junctions from being added/converted to an AND junction and vice versa. This was only affecting certain query paths.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/AbstractGroupOrRangeJunction.java a14dda8
geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/CompactRangeIndexQueryDUnitTest.java 8b27309
Diff: https://reviews.apache.org/r/51735/diff/
Testing
-------
Thanks,
Jason Huynh
Re: Review Request 51735: GEODE-1840: Certain map queries combine OR
predicates into an AND junction
Posted by nabarun nag <nn...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51735/#review148586
-----------------------------------------------------------
geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/CompactRangeIndexQueryDUnitTest.java (line 100)
<https://reviews.apache.org/r/51735/#comment216042>
ccountrycy field was never set. I was wondering if that is a necessity in this test.
- nabarun nag
On Sept. 8, 2016, 10:26 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51735/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2016, 10:26 p.m.)
>
>
> Review request for geode, Barry Oglesby and nabarun nag.
>
>
> Repository: geode
>
>
> Description
> -------
>
> When deciding whether to combine the predicates into a common junction, the type should be checked to make sure they are the same. This will prevent OR junctions from being added/converted to an AND junction and vice versa. This was only affecting certain query paths.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/AbstractGroupOrRangeJunction.java a14dda8
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/CompactRangeIndexQueryDUnitTest.java 8b27309
>
> Diff: https://reviews.apache.org/r/51735/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>
Re: Review Request 51735: GEODE-1840: Certain map queries combine OR
predicates into an AND junction
Posted by nabarun nag <nn...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51735/#review148587
-----------------------------------------------------------
Ship it!
Ship It!
- nabarun nag
On Sept. 8, 2016, 10:26 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51735/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2016, 10:26 p.m.)
>
>
> Review request for geode, Barry Oglesby and nabarun nag.
>
>
> Repository: geode
>
>
> Description
> -------
>
> When deciding whether to combine the predicates into a common junction, the type should be checked to make sure they are the same. This will prevent OR junctions from being added/converted to an AND junction and vice versa. This was only affecting certain query paths.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/cache/query/internal/AbstractGroupOrRangeJunction.java a14dda8
> geode-core/src/test/java/com/gemstone/gemfire/cache/query/dunit/CompactRangeIndexQueryDUnitTest.java 8b27309
>
> Diff: https://reviews.apache.org/r/51735/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>