You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2019/07/13 00:26:11 UTC

[GitHub] [phoenix] twdsilva opened a new pull request #541: PHOENIX-4893 Move parent column combining logic of view and view inde…

twdsilva opened a new pull request #541: PHOENIX-4893 Move parent column combining logic of view and view inde…
URL: https://github.com/apache/phoenix/pull/541
 
 
   …xes from server to client
   
   This PR moves the column combining logic from the server to the client. For older clients since the child view metadata included the parent column metadata as well when we return the ```PTable``` from the server it will already include parent table column metadata. 
   I moved the add and drop column code in ```MetadataEndpointImpl``` that was present in anonymous classes that implemented ```ColumnMutator``` into their own classes  ```AddColumnMutator``` and ```DropColumnMutator```. 
   I also renamed ```ViewFinder``` to ```ViewUtil``` and moved the column combining logic from ```MetadataEndpointImpl``` and the code that adds indexes from parent tables from ```MetadataClient``` to this util.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services