[jira] [Commented] (OAK-8185) Improve CompositeNodeStore fixture

["Tomek Rękawek (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-8185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16818904#comment-16818904 ] 

Tomek Rękawek commented on OAK-8185:
------------------------------------

In the [r1857640|https://svn.apache.org/r1857640] I updated the fixture, to resemble the production case I mentioned. Creating the /apps and /libs can't be a part of the benchmark (as it gets the Composite-based Oak instance, where these subtrees are already immutable), so I created a method {{org.apache.jackrabbit.oak.fixture.CompositeStoreFixture#populateSeed}}, empty for now.

> Improve CompositeNodeStore fixture
> ----------------------------------
>
>                 Key: OAK-8185
>                 URL: https://issues.apache.org/jira/browse/OAK-8185
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: benchmarks
>            Reporter: Marcel Reutegger
>            Assignee: Tomek Rękawek
>            Priority: Minor
>         Attachments: OAK-8185-update-fixture.patch, composite-node-builder.txt
>
>
> While working on OAK-8141 I noticed the benchmark numbers for GetDeepNodeTest on Oak-Composite-Store are rather low compared to Oak-Segment-Tar.
> {noformat}
> Apache Jackrabbit Oak 1.12-SNAPSHOT
> # GetDeepNodeTest                  C     min     10%     50%     90%     max       N 
> Oak-Segment-Tar                    1      35      37      39      41      64    1524
> Oak-Composite-Store                1     203     204     208     214     236     288
> {noformat}
> In an offline conversation [~tomek.rekawek] mentioned the overhead shouldn't be that big because the implementation should switch to the non-composite implementation as soon as the read operation traverses into the global/writable node store. It seems however, this is not the case  when running GetDeepNodeTest. So, this may well be a bug and not an improvement, as filed at the moment.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)