You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/12/19 09:34:39 UTC

[GitHub] [kafka] showuon opened a new pull request, #13015: KAFKA-14529: set inter.broker.protocol.version to pass broker registration

showuon opened a new pull request, #13015:
URL: https://github.com/apache/kafka/pull/13015

   
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on pull request #13015: KAFKA-14529: set inter.broker.protocol.version to pass broker registration

Posted by GitBox <gi...@apache.org>.
showuon commented on PR #13015:
URL: https://github.com/apache/kafka/pull/13015#issuecomment-1357599437

   @mumrah @cmccabe , please take a look. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mumrah commented on pull request #13015: KAFKA-14529: set inter.broker.protocol.version to pass broker registration

Posted by GitBox <gi...@apache.org>.
mumrah commented on PR #13015:
URL: https://github.com/apache/kafka/pull/13015#issuecomment-1358030527

   I opened a PR here https://github.com/apache/kafka/pull/13020 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on a diff in pull request #13015: KAFKA-14529: set inter.broker.protocol.version to pass broker registration

Posted by GitBox <gi...@apache.org>.
showuon commented on code in PR #13015:
URL: https://github.com/apache/kafka/pull/13015#discussion_r1052162050


##########
core/src/test/java/kafka/test/junit/ZkClusterInvocationContext.java:
##########
@@ -109,7 +109,9 @@ public void modifyConfigs(Seq<Properties> props) {
                     @Override
                     public Properties serverConfig() {
                         Properties props = clusterConfig.serverProperties();
-                        props.put(KafkaConfig.InterBrokerProtocolVersionProp(), metadataVersion().version());
+                        if (!props.containsKey(KafkaConfig.InterBrokerProtocolVersionProp())) {
+                            props.put(KafkaConfig.InterBrokerProtocolVersionProp(), metadataVersion().version());

Review Comment:
   We used to override IBP to the latest version, which stops us from setting custom IBP using annotation. Update it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon closed pull request #13015: KAFKA-14529: set inter.broker.protocol.version to pass broker registration

Posted by GitBox <gi...@apache.org>.
showuon closed pull request #13015: KAFKA-14529: set inter.broker.protocol.version to pass broker registration
URL: https://github.com/apache/kafka/pull/13015


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on a diff in pull request #13015: KAFKA-14529: set inter.broker.protocol.version to pass broker registration

Posted by GitBox <gi...@apache.org>.
showuon commented on code in PR #13015:
URL: https://github.com/apache/kafka/pull/13015#discussion_r1052162050


##########
core/src/test/java/kafka/test/junit/ZkClusterInvocationContext.java:
##########
@@ -109,7 +109,9 @@ public void modifyConfigs(Seq<Properties> props) {
                     @Override
                     public Properties serverConfig() {
                         Properties props = clusterConfig.serverProperties();
-                        props.put(KafkaConfig.InterBrokerProtocolVersionProp(), metadataVersion().version());
+                        if (!props.containsKey(KafkaConfig.InterBrokerProtocolVersionProp())) {
+                            props.put(KafkaConfig.InterBrokerProtocolVersionProp(), metadataVersion().version());

Review Comment:
   We used to override IBP to the latest version, which stops us from setting custom IBP using annotation. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org