You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "zhouyanming (JIRA)" <ji...@apache.org> on 2007/08/08 11:28:38 UTC

[jira] Created: (WW-2092) UI tags can't custom html tag attributes

UI tags can't  custom html tag attributes
-----------------------------------------

                 Key: WW-2092
                 URL: https://issues.apache.org/struts/browse/WW-2092
             Project: Struts 2
          Issue Type: Improvement
          Components: Views
            Reporter: zhouyanming


for example  <input type="text" name="text" autocomplete="off"/> can't use <s:textfield name="test" autocomplete="off"/> because autocomplete is not valid for this jsp tag.
I suggest add a new jsp tag attribute for all UI tags like this
<s:textfield name="test" tagAttributes="#{'autocomplete':'off','onsuccess':'alert(\'success\')','onfailure':'alert(\'failure\')'}"/>
tagAttributes is a map,and this tag result to
<input type="text" name="text" autocomplete="off" onsuccess="alert('success')" onfailure="alert('failure')"/>

also can add another attribute 'templateParameters',this attribute like 'tagAttributes',but it's used for custom freemarker template.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WW-2092) UI tags can't custom html tag attributes

Posted by "James Holmes (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Holmes updated WW-2092:
-----------------------------

    Affects Version/s: 2.1.x
                       2.0.9
        Fix Version/s:     (was: Future)
                       2.0.11

> UI tags can't  custom html tag attributes
> -----------------------------------------
>
>                 Key: WW-2092
>                 URL: https://issues.apache.org/struts/browse/WW-2092
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Views
>    Affects Versions: 2.0.9, 2.1.x
>            Reporter: zhouyanming
>            Assignee: Don Brown
>             Fix For: 2.0.11
>
>
> for example  <input type="text" name="text" autocomplete="off"/> can't use <s:textfield name="test" autocomplete="off"/> because autocomplete is not valid for this jsp tag.
> I suggest add a new jsp tag attribute for all UI tags like this
> <s:textfield name="test" tagAttributes="#{'autocomplete':'off','onsuccess':'alert(\'success\')','onfailure':'alert(\'failure\')'}"/>
> tagAttributes is a map,and this tag result to
> <input type="text" name="text" autocomplete="off" onsuccess="alert('success')" onfailure="alert('failure')"/>
> also can add another attribute 'templateParameters',this attribute like 'tagAttributes',but it's used for custom freemarker template.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-2092) Update UI tags to allow custom html tag attributes

Posted by "James Holmes (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41912 ] 

James Holmes commented on WW-2092:
----------------------------------

That's cool. We can continue to discuss. Can you post a link with info on the var-arg JSP functionality you mention?

> Update UI tags to allow custom html tag attributes
> --------------------------------------------------
>
>                 Key: WW-2092
>                 URL: https://issues.apache.org/struts/browse/WW-2092
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Views
>    Affects Versions: 2.0.9, 2.1.x
>            Reporter: zhouyanming
>            Assignee: James Holmes
>             Fix For: 2.0.11
>
>         Attachments: src.zip
>
>
> for example  <input type="text" name="text" autocomplete="off"/> can't use <s:textfield name="test" autocomplete="off"/> because autocomplete is not valid for this jsp tag.
> I suggest add a new jsp tag attribute for all UI tags like this
> <s:textfield name="test" tagAttributes="#{'autocomplete':'off','onsuccess':'alert(\'success\')','onfailure':'alert(\'failure\')'}"/>
> tagAttributes is a map,and this tag result to
> <input type="text" name="text" autocomplete="off" onsuccess="alert('success')" onfailure="alert('failure')"/>
> also can add another attribute 'templateParameters',this attribute like 'tagAttributes',but it's used for custom freemarker template.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WW-2092) UI tags can't custom html tag attributes

Posted by "James Holmes (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Holmes updated WW-2092:
-----------------------------

    Affects Version/s: Future

I don't have a use for this now, but I like the concept of it. I would recommend using an attribute named "extraAttributes"  (or something along that line) instead of "tagAttributes". 

> UI tags can't  custom html tag attributes
> -----------------------------------------
>
>                 Key: WW-2092
>                 URL: https://issues.apache.org/struts/browse/WW-2092
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Views
>    Affects Versions: Future
>            Reporter: zhouyanming
>            Assignee: Don Brown
>
> for example  <input type="text" name="text" autocomplete="off"/> can't use <s:textfield name="test" autocomplete="off"/> because autocomplete is not valid for this jsp tag.
> I suggest add a new jsp tag attribute for all UI tags like this
> <s:textfield name="test" tagAttributes="#{'autocomplete':'off','onsuccess':'alert(\'success\')','onfailure':'alert(\'failure\')'}"/>
> tagAttributes is a map,and this tag result to
> <input type="text" name="text" autocomplete="off" onsuccess="alert('success')" onfailure="alert('failure')"/>
> also can add another attribute 'templateParameters',this attribute like 'tagAttributes',but it's used for custom freemarker template.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-2092) Update UI tags to allow custom html tag attributes

Posted by "kernel (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43641#action_43641 ] 

kernel commented on WW-2092:
----------------------------

I understand that this matter requires to be thought through before any further actions, although turning off the autocompletition feature is important in security sensitive cases.(not only for input, but for form tags too)

We've just started to work on a project that can't go live without the availability of this feature, and it would be great if it was included in one of the versions before 2.1.



> Update UI tags to allow custom html tag attributes
> --------------------------------------------------
>
>                 Key: WW-2092
>                 URL: https://issues.apache.org/struts/browse/WW-2092
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - Tags
>    Affects Versions: 2.0.9, 2.1.x
>            Reporter: zhouyanming
>            Assignee: James Holmes
>             Fix For: 2.1.x
>
>         Attachments: extra.patch, src.zip
>
>
> for example  <input type="text" name="text" autocomplete="off"/> can't use <s:textfield name="test" autocomplete="off"/> because autocomplete is not valid for this jsp tag.
> I suggest add a new jsp tag attribute for all UI tags like this
> <s:textfield name="test" tagAttributes="#{'autocomplete':'off','onsuccess':'alert(\'success\')','onfailure':'alert(\'failure\')'}"/>
> tagAttributes is a map,and this tag result to
> <input type="text" name="text" autocomplete="off" onsuccess="alert('success')" onfailure="alert('failure')"/>
> also can add another attribute 'templateParameters',this attribute like 'tagAttributes',but it's used for custom freemarker template.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WW-2092) Update UI tags to allow custom html tag attributes

Posted by "James Holmes (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Holmes updated WW-2092:
-----------------------------

    Fix Version/s: 2.1.3

> Update UI tags to allow custom html tag attributes
> --------------------------------------------------
>
>                 Key: WW-2092
>                 URL: https://issues.apache.org/struts/browse/WW-2092
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - Tags
>    Affects Versions: 2.0.9
>            Reporter: zhouyanming
>            Assignee: James Holmes
>             Fix For: 2.1.3
>
>         Attachments: extra.patch, src.zip
>
>
> for example  <input type="text" name="text" autocomplete="off"/> can't use <s:textfield name="test" autocomplete="off"/> because autocomplete is not valid for this jsp tag.
> I suggest add a new jsp tag attribute for all UI tags like this
> <s:textfield name="test" tagAttributes="#{'autocomplete':'off','onsuccess':'alert(\'success\')','onfailure':'alert(\'failure\')'}"/>
> tagAttributes is a map,and this tag result to
> <input type="text" name="text" autocomplete="off" onsuccess="alert('success')" onfailure="alert('failure')"/>
> also can add another attribute 'templateParameters',this attribute like 'tagAttributes',but it's used for custom freemarker template.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WW-2092) Update UI tags to allow custom html tag attributes

Posted by "zhouyanming (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

zhouyanming reassigned WW-2092:
-------------------------------

    Assignee: James Holmes  (was: Don Brown)

> Update UI tags to allow custom html tag attributes
> --------------------------------------------------
>
>                 Key: WW-2092
>                 URL: https://issues.apache.org/struts/browse/WW-2092
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Views
>    Affects Versions: 2.0.9, 2.1.x
>            Reporter: zhouyanming
>            Assignee: James Holmes
>             Fix For: 2.0.11
>
>         Attachments: src.zip
>
>
> for example  <input type="text" name="text" autocomplete="off"/> can't use <s:textfield name="test" autocomplete="off"/> because autocomplete is not valid for this jsp tag.
> I suggest add a new jsp tag attribute for all UI tags like this
> <s:textfield name="test" tagAttributes="#{'autocomplete':'off','onsuccess':'alert(\'success\')','onfailure':'alert(\'failure\')'}"/>
> tagAttributes is a map,and this tag result to
> <input type="text" name="text" autocomplete="off" onsuccess="alert('success')" onfailure="alert('failure')"/>
> also can add another attribute 'templateParameters',this attribute like 'tagAttributes',but it's used for custom freemarker template.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-2092) UI tags can't custom html tag attributes

Posted by "zhouyanming (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41872 ] 

zhouyanming commented on WW-2092:
---------------------------------

I agree with 'extraAttributes'

> UI tags can't  custom html tag attributes
> -----------------------------------------
>
>                 Key: WW-2092
>                 URL: https://issues.apache.org/struts/browse/WW-2092
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Views
>            Reporter: zhouyanming
>            Assignee: Don Brown
>             Fix For: Future
>
>
> for example  <input type="text" name="text" autocomplete="off"/> can't use <s:textfield name="test" autocomplete="off"/> because autocomplete is not valid for this jsp tag.
> I suggest add a new jsp tag attribute for all UI tags like this
> <s:textfield name="test" tagAttributes="#{'autocomplete':'off','onsuccess':'alert(\'success\')','onfailure':'alert(\'failure\')'}"/>
> tagAttributes is a map,and this tag result to
> <input type="text" name="text" autocomplete="off" onsuccess="alert('success')" onfailure="alert('failure')"/>
> also can add another attribute 'templateParameters',this attribute like 'tagAttributes',but it's used for custom freemarker template.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-2092) Update UI tags to allow custom html tag attributes

Posted by "James Holmes (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41916 ] 

James Holmes commented on WW-2092:
----------------------------------

Here is a link to the Stripes page on dynamic attributes:

http://mc4j.org/confluence/display/stripes/Tag+Library+Doc

After reviewing this I tend to agree with Don about thinking through this a little more. It would probably be best to have a dynamic version of the Struts 2 TLD.

> Update UI tags to allow custom html tag attributes
> --------------------------------------------------
>
>                 Key: WW-2092
>                 URL: https://issues.apache.org/struts/browse/WW-2092
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Views
>    Affects Versions: 2.0.9, 2.1.x
>            Reporter: zhouyanming
>            Assignee: James Holmes
>             Fix For: 2.1.x
>
>         Attachments: extra.patch, src.zip
>
>
> for example  <input type="text" name="text" autocomplete="off"/> can't use <s:textfield name="test" autocomplete="off"/> because autocomplete is not valid for this jsp tag.
> I suggest add a new jsp tag attribute for all UI tags like this
> <s:textfield name="test" tagAttributes="#{'autocomplete':'off','onsuccess':'alert(\'success\')','onfailure':'alert(\'failure\')'}"/>
> tagAttributes is a map,and this tag result to
> <input type="text" name="text" autocomplete="off" onsuccess="alert('success')" onfailure="alert('failure')"/>
> also can add another attribute 'templateParameters',this attribute like 'tagAttributes',but it's used for custom freemarker template.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-2092) Update UI tags to allow custom html tag attributes

Posted by "Don Brown (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41911 ] 

Don Brown commented on WW-2092:
-------------------------------

I'm not so sure this should go into 2.0.11.  This seems like a bigger feature we should think through more.  I don't really like the idea of stuffing extra attributes in this manner, and would prefer something more structured like the var-arg-type functionality for jsp tags.  In fact, I'm pretty sure this feature needs more review/discussion before it should go in.

> Update UI tags to allow custom html tag attributes
> --------------------------------------------------
>
>                 Key: WW-2092
>                 URL: https://issues.apache.org/struts/browse/WW-2092
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Views
>    Affects Versions: 2.0.9, 2.1.x
>            Reporter: zhouyanming
>            Assignee: James Holmes
>             Fix For: 2.0.11
>
>         Attachments: src.zip
>
>
> for example  <input type="text" name="text" autocomplete="off"/> can't use <s:textfield name="test" autocomplete="off"/> because autocomplete is not valid for this jsp tag.
> I suggest add a new jsp tag attribute for all UI tags like this
> <s:textfield name="test" tagAttributes="#{'autocomplete':'off','onsuccess':'alert(\'success\')','onfailure':'alert(\'failure\')'}"/>
> tagAttributes is a map,and this tag result to
> <input type="text" name="text" autocomplete="off" onsuccess="alert('success')" onfailure="alert('failure')"/>
> also can add another attribute 'templateParameters',this attribute like 'tagAttributes',but it's used for custom freemarker template.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WW-2092) Update UI tags to allow custom html tag attributes

Posted by "zhouyanming (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

zhouyanming updated WW-2092:
----------------------------

    Attachment: src.zip

I have add two attributes for UI Tag

extraAttributes:
Set extra attributes render as html element attributes
	
extraParameters:
Set extra parameters if need to custom template,this will not override parameter exists

> Update UI tags to allow custom html tag attributes
> --------------------------------------------------
>
>                 Key: WW-2092
>                 URL: https://issues.apache.org/struts/browse/WW-2092
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Views
>    Affects Versions: 2.0.9, 2.1.x
>            Reporter: zhouyanming
>            Assignee: Don Brown
>             Fix For: 2.0.11
>
>         Attachments: src.zip
>
>
> for example  <input type="text" name="text" autocomplete="off"/> can't use <s:textfield name="test" autocomplete="off"/> because autocomplete is not valid for this jsp tag.
> I suggest add a new jsp tag attribute for all UI tags like this
> <s:textfield name="test" tagAttributes="#{'autocomplete':'off','onsuccess':'alert(\'success\')','onfailure':'alert(\'failure\')'}"/>
> tagAttributes is a map,and this tag result to
> <input type="text" name="text" autocomplete="off" onsuccess="alert('success')" onfailure="alert('failure')"/>
> also can add another attribute 'templateParameters',this attribute like 'tagAttributes',but it's used for custom freemarker template.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WW-2092) Update UI tags to allow custom html tag attributes

Posted by "James Holmes (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Holmes resolved WW-2092.
------------------------------

    Resolution: Duplicate

> Update UI tags to allow custom html tag attributes
> --------------------------------------------------
>
>                 Key: WW-2092
>                 URL: https://issues.apache.org/struts/browse/WW-2092
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Views
>    Affects Versions: 2.0.9, 2.1.x
>            Reporter: zhouyanming
>            Assignee: James Holmes
>             Fix For: 2.1.x
>
>         Attachments: extra.patch, src.zip
>
>
> for example  <input type="text" name="text" autocomplete="off"/> can't use <s:textfield name="test" autocomplete="off"/> because autocomplete is not valid for this jsp tag.
> I suggest add a new jsp tag attribute for all UI tags like this
> <s:textfield name="test" tagAttributes="#{'autocomplete':'off','onsuccess':'alert(\'success\')','onfailure':'alert(\'failure\')'}"/>
> tagAttributes is a map,and this tag result to
> <input type="text" name="text" autocomplete="off" onsuccess="alert('success')" onfailure="alert('failure')"/>
> also can add another attribute 'templateParameters',this attribute like 'tagAttributes',but it's used for custom freemarker template.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-2092) Update UI tags to allow custom html tag attributes

Posted by "James Holmes (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41910 ] 

James Holmes commented on WW-2092:
----------------------------------

Thanks for submitting the code. I'm happy to work on this ticket, but it's difficult to know what all has changed when you provide an updated copy of the source files. It's much easier to work with diff files. The following link explains the details on creating diff patch files:

http://www.apache.org/dev/contributors.html#patches

> Update UI tags to allow custom html tag attributes
> --------------------------------------------------
>
>                 Key: WW-2092
>                 URL: https://issues.apache.org/struts/browse/WW-2092
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Views
>    Affects Versions: 2.0.9, 2.1.x
>            Reporter: zhouyanming
>            Assignee: James Holmes
>             Fix For: 2.0.11
>
>         Attachments: src.zip
>
>
> for example  <input type="text" name="text" autocomplete="off"/> can't use <s:textfield name="test" autocomplete="off"/> because autocomplete is not valid for this jsp tag.
> I suggest add a new jsp tag attribute for all UI tags like this
> <s:textfield name="test" tagAttributes="#{'autocomplete':'off','onsuccess':'alert(\'success\')','onfailure':'alert(\'failure\')'}"/>
> tagAttributes is a map,and this tag result to
> <input type="text" name="text" autocomplete="off" onsuccess="alert('success')" onfailure="alert('failure')"/>
> also can add another attribute 'templateParameters',this attribute like 'tagAttributes',but it's used for custom freemarker template.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WW-2092) Update UI tags to allow custom html tag attributes

Posted by "zhouyanming (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

zhouyanming updated WW-2092:
----------------------------

    Attachment: extra.patch

FYI,here is a patch

> Update UI tags to allow custom html tag attributes
> --------------------------------------------------
>
>                 Key: WW-2092
>                 URL: https://issues.apache.org/struts/browse/WW-2092
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Views
>    Affects Versions: 2.0.9, 2.1.x
>            Reporter: zhouyanming
>            Assignee: James Holmes
>             Fix For: 2.1.x
>
>         Attachments: extra.patch, src.zip
>
>
> for example  <input type="text" name="text" autocomplete="off"/> can't use <s:textfield name="test" autocomplete="off"/> because autocomplete is not valid for this jsp tag.
> I suggest add a new jsp tag attribute for all UI tags like this
> <s:textfield name="test" tagAttributes="#{'autocomplete':'off','onsuccess':'alert(\'success\')','onfailure':'alert(\'failure\')'}"/>
> tagAttributes is a map,and this tag result to
> <input type="text" name="text" autocomplete="off" onsuccess="alert('success')" onfailure="alert('failure')"/>
> also can add another attribute 'templateParameters',this attribute like 'tagAttributes',but it's used for custom freemarker template.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WW-2092) UI tags can't custom html tag attributes

Posted by "James Holmes (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Holmes updated WW-2092:
-----------------------------

    Affects Version/s:     (was: Future)
        Fix Version/s: Future

> UI tags can't  custom html tag attributes
> -----------------------------------------
>
>                 Key: WW-2092
>                 URL: https://issues.apache.org/struts/browse/WW-2092
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Views
>            Reporter: zhouyanming
>            Assignee: Don Brown
>             Fix For: Future
>
>
> for example  <input type="text" name="text" autocomplete="off"/> can't use <s:textfield name="test" autocomplete="off"/> because autocomplete is not valid for this jsp tag.
> I suggest add a new jsp tag attribute for all UI tags like this
> <s:textfield name="test" tagAttributes="#{'autocomplete':'off','onsuccess':'alert(\'success\')','onfailure':'alert(\'failure\')'}"/>
> tagAttributes is a map,and this tag result to
> <input type="text" name="text" autocomplete="off" onsuccess="alert('success')" onfailure="alert('failure')"/>
> also can add another attribute 'templateParameters',this attribute like 'tagAttributes',but it's used for custom freemarker template.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WW-2092) Update UI tags to allow custom html tag attributes

Posted by "Don Brown (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Don Brown updated WW-2092:
--------------------------

    Fix Version/s:     (was: 2.0.11)
                   2.1.x

See: http://java.sun.com/j2ee/1.4/docs/tutorial/doc/JSPTags4.html under dynamic attributes.  The question is whether this is a good idea or not.  If you allow dynamic attributes, it is harder for tools like idea to provide autocomplete and validation.  Stripes solves this by shipping two TLD's, one that allows and one that doesn't.

> Update UI tags to allow custom html tag attributes
> --------------------------------------------------
>
>                 Key: WW-2092
>                 URL: https://issues.apache.org/struts/browse/WW-2092
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Views
>    Affects Versions: 2.0.9, 2.1.x
>            Reporter: zhouyanming
>            Assignee: James Holmes
>             Fix For: 2.1.x
>
>         Attachments: src.zip
>
>
> for example  <input type="text" name="text" autocomplete="off"/> can't use <s:textfield name="test" autocomplete="off"/> because autocomplete is not valid for this jsp tag.
> I suggest add a new jsp tag attribute for all UI tags like this
> <s:textfield name="test" tagAttributes="#{'autocomplete':'off','onsuccess':'alert(\'success\')','onfailure':'alert(\'failure\')'}"/>
> tagAttributes is a map,and this tag result to
> <input type="text" name="text" autocomplete="off" onsuccess="alert('success')" onfailure="alert('failure')"/>
> also can add another attribute 'templateParameters',this attribute like 'tagAttributes',but it's used for custom freemarker template.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WW-2092) Update UI tags to allow custom html tag attributes

Posted by "James Holmes (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Holmes updated WW-2092:
-----------------------------

    Summary: Update UI tags to allow custom html tag attributes  (was: UI tags can't  custom html tag attributes)

> Update UI tags to allow custom html tag attributes
> --------------------------------------------------
>
>                 Key: WW-2092
>                 URL: https://issues.apache.org/struts/browse/WW-2092
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Views
>    Affects Versions: 2.0.9, 2.1.x
>            Reporter: zhouyanming
>            Assignee: Don Brown
>             Fix For: 2.0.11
>
>
> for example  <input type="text" name="text" autocomplete="off"/> can't use <s:textfield name="test" autocomplete="off"/> because autocomplete is not valid for this jsp tag.
> I suggest add a new jsp tag attribute for all UI tags like this
> <s:textfield name="test" tagAttributes="#{'autocomplete':'off','onsuccess':'alert(\'success\')','onfailure':'alert(\'failure\')'}"/>
> tagAttributes is a map,and this tag result to
> <input type="text" name="text" autocomplete="off" onsuccess="alert('success')" onfailure="alert('failure')"/>
> also can add another attribute 'templateParameters',this attribute like 'tagAttributes',but it's used for custom freemarker template.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WW-2092) UI tags can't custom html tag attributes

Posted by "zhouyanming (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

zhouyanming reassigned WW-2092:
-------------------------------

    Assignee: Don Brown

> UI tags can't  custom html tag attributes
> -----------------------------------------
>
>                 Key: WW-2092
>                 URL: https://issues.apache.org/struts/browse/WW-2092
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Views
>            Reporter: zhouyanming
>            Assignee: Don Brown
>
> for example  <input type="text" name="text" autocomplete="off"/> can't use <s:textfield name="test" autocomplete="off"/> because autocomplete is not valid for this jsp tag.
> I suggest add a new jsp tag attribute for all UI tags like this
> <s:textfield name="test" tagAttributes="#{'autocomplete':'off','onsuccess':'alert(\'success\')','onfailure':'alert(\'failure\')'}"/>
> tagAttributes is a map,and this tag result to
> <input type="text" name="text" autocomplete="off" onsuccess="alert('success')" onfailure="alert('failure')"/>
> also can add another attribute 'templateParameters',this attribute like 'tagAttributes',but it's used for custom freemarker template.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.