You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/03/11 08:00:50 UTC

[GitHub] [iceberg] chenjunjiedada opened a new pull request #2321: Spark: fix invalid unit test

chenjunjiedada opened a new pull request #2321:
URL: https://github.com/apache/iceberg/pull/2321


   The unit test `testEqualityDeleteWithFilter` create the table by itself but not create test data. Looks like the idea is to use the same test data from its base class.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] chenjunjiedada commented on pull request #2321: Spark: Improve the test case testEqualityDeleteWithFilter

Posted by GitBox <gi...@apache.org>.
chenjunjiedada commented on pull request #2321:
URL: https://github.com/apache/iceberg/pull/2321#issuecomment-797185398


   Some Flink unit tests failed.  Could you re-run the CI? I can close and reopen the PR if necessary.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] openinx commented on a change in pull request #2321: Spark: fix invalid unit test

Posted by GitBox <gi...@apache.org>.
openinx commented on a change in pull request #2321:
URL: https://github.com/apache/iceberg/pull/2321#discussion_r592198495



##########
File path: spark/src/test/java/org/apache/iceberg/spark/source/TestSparkReaderDeletes.java
##########
@@ -129,6 +129,18 @@ public StructLikeSet rowSet(String name, Table table, String... columns) {
   public void testEqualityDeleteWithFilter() throws IOException {
     String tableName = "test_with_filter";
     Table table = createTable(tableName, SCHEMA, SPEC);
+

Review comment:
       Why not just use the created `test` table ( in `writeTestDataFile` annotated with a `Before` )  ? then we don't have to write those rows again for this newly created `test_with_filter` table.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] openinx commented on pull request #2321: Spark: Improve the test case testEqualityDeleteWithFilter

Posted by GitBox <gi...@apache.org>.
openinx commented on pull request #2321:
URL: https://github.com/apache/iceberg/pull/2321#issuecomment-797190843


   I don't think this patch will affect the flink unit tests. Got this merged now, will take a look to the flink unit tests.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] aokolnychyi commented on a change in pull request #2321: Spark: fix invalid unit test

Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on a change in pull request #2321:
URL: https://github.com/apache/iceberg/pull/2321#discussion_r592841067



##########
File path: spark/src/test/java/org/apache/iceberg/spark/source/TestSparkReaderDeletes.java
##########
@@ -129,6 +129,18 @@ public StructLikeSet rowSet(String name, Table table, String... columns) {
   public void testEqualityDeleteWithFilter() throws IOException {
     String tableName = "test_with_filter";
     Table table = createTable(tableName, SCHEMA, SPEC);
+

Review comment:
       +1 to what @openinx suggests. Then we also don't need to reason about dropping the table.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] openinx merged pull request #2321: Spark: Improve the test case testEqualityDeleteWithFilter

Posted by GitBox <gi...@apache.org>.
openinx merged pull request #2321:
URL: https://github.com/apache/iceberg/pull/2321


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] openinx commented on pull request #2321: Spark: Improve the test case testEqualityDeleteWithFilter

Posted by GitBox <gi...@apache.org>.
openinx commented on pull request #2321:
URL: https://github.com/apache/iceberg/pull/2321#issuecomment-797179935


   LGTM, +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org