You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "ZuebeyirEser (via GitHub)" <gi...@apache.org> on 2026/01/24 15:13:36 UTC
[PR] [test] Fix flaky AdjustIsrITCase by retrying produce request [fluss]
ZuebeyirEser opened a new pull request, #2468:
URL: https://github.com/apache/fluss/pull/2468
<!--
*Thank you very much for contributing to Fluss - we are happy that you want to help us improve Fluss. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [GitHub issue](https://github.com/apache/fluss/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no issue.
- Name the pull request in the format "[component] Title of the pull request", where *[component]* should be replaced by the name of the component being changed. Typically, this corresponds to the component label assigned to the issue (e.g., [kv], [log], [client], [flink]). Skip *[component]* if you are unsure about which is the best component.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes.
- Each pull request should address only one issue, not mix up code from multiple issues.
**(The sections below can be removed for hotfixes or typos)**
-->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #2242
<!-- What is the purpose of the change -->
Fixes the flaky integration test `AdjustIsrITCase.testIsrShrinkAndExpand` by accounting for the delay in ISR shrinkage detection.
### Brief change log
**The Problem:**
The test was failing intermittently because it attempted to execute a `produceLog` request immediately after stopping a follower replica. Due to the `LOG_REPLICA_MAX_LAG_TIME` configuration (3 seconds), there is a delay before the Leader detects the follower failure and shrinks the In-Sync Replicas (ISR) set. During this window:
1. The Leader waits for acknowledgment from the stopped follower (still in ISR)
2. The request fails with `NOT_ENOUGH_REPLICAS` or `TIMEOUT`
3. The test fails with `AssertionFailedError: Expecting value to be false but was true`
**The Fix:**
Modified `testIsrShrinkAndExpand` to wrap the produce request in a `retry` block, allowing the Leader sufficient time to detect the follower failure and shrink the ISR before proceeding with the write operation.
<!-- Please describe the changes made in this pull request and explain how they address the issue -->
### Tests
- **Reproduction:** Reproduced the failure locally by increasing `LOG_REPLICA_MAX_LAG_TIME` to 60s, causing 100% test failure with the original code
- **Validation:** Applied the fix and verified consistent test passes, even with artificial delays
- **Regression:** Ran `mvn test -pl fluss-server -Dtest=AdjustIsrITCase` to ensure stability
<!-- List UT and IT cases to verify this change -->
### API and Format
- Dependencies: **no**
- Public API: **no**
- Schema: **no**
- Default configuration values: **no**
- Wire protocol: **no**
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
**no** - This is a test-only fix with no user-facing changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [test] Fix flaky AdjustIsrITCase by retrying produce request [fluss]
Posted by "ZuebeyirEser (via GitHub)" <gi...@apache.org>.
ZuebeyirEser commented on PR #2468:
URL: https://github.com/apache/fluss/pull/2468#issuecomment-3796436881
@wuchong Agreed.
I took a closer look at `RpcMessageTestUtils` to verify the timing, and found it has 10s timeout. Since `LOG_REPLICA_MAX_LAG_TIME` is 3s, the ZK overhead on CI was pushing the total wait past that 10s limit.
Switching to `acks=1` bypasses that client timeout entirely while still triggering the shrink. Much cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [test] Fix flaky AdjustIsrITCase by retrying produce request [fluss]
Posted by "wuchong (via GitHub)" <gi...@apache.org>.
wuchong merged PR #2468:
URL: https://github.com/apache/fluss/pull/2468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [test] Fix flaky AdjustIsrITCase by retrying produce request [fluss]
Posted by "wuchong (via GitHub)" <gi...@apache.org>.
wuchong commented on PR #2468:
URL: https://github.com/apache/fluss/pull/2468#issuecomment-3795957426
Thanks, @ZuebeyirEser, for the thorough investigation. While the current fix works, I think there’s a simpler approach.
Since `produceLog` is only used to trigger ISR shrinking and doesn’t require strong durability guarantees, it doesn’t need to wait for full ISR acknowledgment. We can set its `acks` to `1`, so the produce request succeeds immediately without waiting for all in-sync replicas.
This still triggers ISR shrinking: since a follower has been stopped, it will exceed `LOG_REPLICA_MAX_LAG_TIME`, prompting the controller to update the LeaderAndIsr in ZooKeeper accordingly.
What do you think, @ZuebeyirEser and @swuferhong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org