[jira] [Commented] (FLINK-8357) enable rolling in default log settings

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16583977#comment-16583977 ] 

ASF GitHub Bot commented on FLINK-8357:
---------------------------------------

GJL commented on issue #5371: [FLINK-8357] [conf] Enable rolling in default log settings
URL: https://github.com/apache/flink/pull/5371#issuecomment-413878586
 
 
   Hi, what's the state of this PR?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> enable rolling in default log settings
> --------------------------------------
>
>                 Key: FLINK-8357
>                 URL: https://issues.apache.org/jira/browse/FLINK-8357
>             Project: Flink
>          Issue Type: Improvement
>          Components: Logging
>            Reporter: Xu Mingmin
>            Assignee: zhangminglei
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>
> The release packages uses {{org.apache.log4j.FileAppender}} for log4j and {{ch.qos.logback.core.FileAppender}} for logback, which could results in very large log files. 
> For most cases, if not all, we need to enable rotation in a production cluster, and I suppose it's a good idea to make rotation as default.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)